Re: [U-Boot] [PATCH v2 15/28] x86: acpi: Change fill_header()

2016-05-08 Thread Bin Meng
On Sun, May 8, 2016 at 2:46 AM, Simon Glass wrote: > On 7 May 2016 at 08:46, Bin Meng wrote: >> Rename fill_header() to acpi_fill_header() for consistency. >> Change its signature to remove the 'length' parameter and >> make it a public API. >> >> Also

Re: [U-Boot] [PATCH v2 15/28] x86: acpi: Change fill_header()

2016-05-07 Thread Simon Glass
On 7 May 2016 at 08:46, Bin Meng wrote: > Rename fill_header() to acpi_fill_header() for consistency. > Change its signature to remove the 'length' parameter and > make it a public API. > > Also remove the unnecessary include files, and improve the > AmlCode[] comment a little

[U-Boot] [PATCH v2 15/28] x86: acpi: Change fill_header()

2016-05-07 Thread Bin Meng
Rename fill_header() to acpi_fill_header() for consistency. Change its signature to remove the 'length' parameter and make it a public API. Also remove the unnecessary include files, and improve the AmlCode[] comment a little bit. Signed-off-by: Bin Meng Reviewed-by: Stefan