Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Marek Vasut
On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: The command gets an arbitrary number of arguments (up to 30), which are interpreted as byte values and are feed into the TPM device after proper initialization. Then the return value and data of the TPM driver is examined.

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
Dear Marek Vasut, thank you for your comments, please see below: On Sat, Oct 15, 2011 at 11:02 AM, Marek Vasut marek.va...@gmail.com wrote: On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: The command gets an arbitrary number of arguments (up to 30), which are interpreted as

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 14:02:29 Marek Vasut wrote: On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: --- /dev/null +++ b/common/cmd_tpm.c @@ -0,0 +1,111 @@ +/* + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. + * Released under the 2-clause BSD

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Friday 14 October 2011 23:39:08 Vadim Bendebury wrote: --- /dev/null +++ b/common/cmd_tpm.c + /* + * Verify that in case it is present, the first argument, it is + * exactly one character in size. + */ + if (argc 7) { + puts(command should be at

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Friday 14 October 2011 23:39:08 Vadim Bendebury wrote: --- a/common/Makefile +++ b/common/Makefile COBJS-$(CONFIG_CMD_UBIFS) += cmd_ubifs.o COBJS-$(CONFIG_CMD_UNIVERSE) += cmd_universe.o COBJS-$(CONFIG_CMD_UNZIP) += cmd_unzip.o +COBJS-$(CONFIG_CMD_TPM) += cmd_tpm.o keep the list

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Wolfgang Denk
Dear Vadim Bendebury, In message cac3gerhaagx39xjd04mnjwe3sa9xc087llpf6sycvc6k7sl...@mail.gmail.com you wrote: + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. + * Released under the 2-clause BSD license. Are we ok with this ? Also, you say something about GPL in

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote: Vadim Bendebury wrote: Two underscores aren't a good practice. I did this as a result of a previous review. Do you have a suggestion how this should be done instead? First, and most important, __u_boot_cmd_tpm appears to be

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger vap...@gentoo.org wrote: On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote: Vadim Bendebury wrote: Two underscores aren't a good practice. I did this as a result of a previous review. Do you have a suggestion how this should be done

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
On Sat, Oct 15, 2011 at 12:08 PM, Mike Frysinger vap...@gentoo.org wrote: On Saturday 15 October 2011 14:02:29 Marek Vasut wrote: On Saturday, October 15, 2011 05:39:08 AM Vadim Bendebury wrote: --- /dev/null +++ b/common/cmd_tpm.c @@ -0,0 +1,111 @@ +/* + * Copyright (c) 2011 The

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Vadim Bendebury
Dear Wolfgang Denk, On Sat, Oct 15, 2011 at 12:44 PM, Wolfgang Denk w...@denx.de wrote: Dear Vadim Bendebury, In message cac3gerhaagx39xjd04mnjwe3sa9xc087llpf6sycvc6k7sl...@mail.gmail.com you wrote: + * Copyright (c) 2011 The Chromium OS Authors. All rights reserved. + * Released

Re: [U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-15 Thread Mike Frysinger
On Saturday 15 October 2011 16:27:02 Vadim Bendebury wrote: On Sat, Oct 15, 2011 at 1:01 PM, Mike Frysinger vap...@gentoo.org wrote: On Saturday 15 October 2011 15:44:04 Wolfgang Denk wrote: Vadim Bendebury wrote: Two underscores aren't a good practice. I did this as a result of a

[U-Boot] [PATCH v2 2/2] Add a cli command to test the TPM device.

2011-10-14 Thread Vadim Bendebury
The command gets an arbitrary number of arguments (up to 30), which are interpreted as byte values and are feed into the TPM device after proper initialization. Then the return value and data of the TPM driver is examined. TPM commands are described in the TCG specification. For instance, the