Re: [U-Boot] [PATCH v2 2/2] lib: net_utils: enforce '.' as octet separator in string_to_ip

2017-01-09 Thread Chris Packham
On Mon, Jan 9, 2017 at 7:45 AM, Wolfgang Denk wrote: > Dear Chris, > > In message > you > wrote: >> >> > The old code was forgiving and would accept 192,168,1,2 as well. >> >> Technically you can't enter that.

Re: [U-Boot] [PATCH v2 2/2] lib: net_utils: enforce '.' as octet separator in string_to_ip

2017-01-08 Thread Wolfgang Denk
Dear Chris, In message you wrote: > > > The old code was forgiving and would accept 192,168,1,2 as well. > > Technically you can't enter that. The env_flags.c code prevents that > from being added to environment variables that

Re: [U-Boot] [PATCH v2 2/2] lib: net_utils: enforce '.' as octet separator in string_to_ip

2017-01-05 Thread Chris Packham
On Wed, Jan 4, 2017 at 11:09 PM, Wolfgang Denk wrote: > Dear Chris Packham, > > In message <20170104003626.4211-2-judge.pack...@gmail.com> you wrote: >> Ensure '.' is used to separate octets. If another character is seen >> reject the string outright and return 0.0.0.0. > > What is

Re: [U-Boot] [PATCH v2 2/2] lib: net_utils: enforce '.' as octet separator in string_to_ip

2017-01-04 Thread Wolfgang Denk
Dear Chris Packham, In message <20170104003626.4211-2-judge.pack...@gmail.com> you wrote: > Ensure '.' is used to separate octets. If another character is seen > reject the string outright and return 0.0.0.0. What is this good for? The old code was forgiving and would accept 192,168,1,2 as

[U-Boot] [PATCH v2 2/2] lib: net_utils: enforce '.' as octet separator in string_to_ip

2017-01-03 Thread Chris Packham
Ensure '.' is used to separate octets. If another character is seen reject the string outright and return 0.0.0.0. Signed-off-by: Chris Packham --- Changes in v2: - new END lib/net_utils.c | 4 1 file changed, 4 insertions(+) diff --git a/lib/net_utils.c