Re: [U-Boot] [PATCH v2 2/4] arm, at91: add function for waiting if reset ends

2013-11-04 Thread Andreas Bießmann
Dear Wolfgang, On 11/04/2013 10:03 AM, Wolfgang Denk wrote: > In message <1383547247-7017-3-git-send-email...@denx.de> you wrote: >> add function for waiting if reset ends. If reset never ends, >> timeout and print an error message. > > I think this patch needs some rework. > > First, I think we

Re: [U-Boot] [PATCH v2 2/4] arm, at91: add function for waiting if reset ends

2013-11-04 Thread Heiko Schocher
Hello Wolfgang, Am 04.11.2013 10:03, schrieb Wolfgang Denk: Dear Heiko, In message<1383547247-7017-3-git-send-email...@denx.de> you wrote: add function for waiting if reset ends. If reset never ends, timeout and print an error message. I think this patch needs some rework. First, I think w

Re: [U-Boot] [PATCH v2 2/4] arm, at91: add function for waiting if reset ends

2013-11-04 Thread Wolfgang Denk
Dear Heiko, In message <1383547247-7017-3-git-send-email...@denx.de> you wrote: > add function for waiting if reset ends. If reset never ends, > timeout and print an error message. I think this patch needs some rework. First, I think we should point out in the commit mnessage that we're not talk

Re: [U-Boot] [PATCH v2 2/4] arm, at91: add function for waiting if reset ends

2013-11-04 Thread Andreas Bießmann
Hi Heiko, On 11/04/2013 07:40 AM, Heiko Schocher wrote: > add function for waiting if reset ends. If reset never ends, > timeout and print an error message. > > Signed-off-by: Heiko Schocher > Cc: Bo Shen > Cc: Andreas Bießmann > > --- > - changes for v2: > - new in v2 > --- > arch/arm/cpu

[U-Boot] [PATCH v2 2/4] arm, at91: add function for waiting if reset ends

2013-11-03 Thread Heiko Schocher
add function for waiting if reset ends. If reset never ends, timeout and print an error message. Signed-off-by: Heiko Schocher Cc: Bo Shen Cc: Andreas Bießmann --- - changes for v2: - new in v2 --- arch/arm/cpu/arm926ejs/at91/reset.c| 15 +++ arch/arm/include/asm/arch-at