Re: [U-Boot] [PATCH v2 22/22] omap: spl: add more debug traces

2011-07-03 Thread Aneesh V
Dear Wolfgang, On Wednesday 15 June 2011 03:48 PM, Wolfgang Denk wrote: > Dear Aneesh V, > [snip ..] >> No. That wouldn't serve the purpose. I need two macros to distinguish >> between the two cases. >> 1. 'debug()' - can be used in all places at which console is guaranteed >> to be initialized

Re: [U-Boot] [PATCH v2 22/22] omap: spl: add more debug traces

2011-06-15 Thread Wolfgang Denk
Dear Aneesh V, In message <4df617c2.6070...@ti.com> you wrote: > > > Console should _always_ be enabled as early as possible, > > Unfortunately this is not the case with U-Boot today. Console > initialization happens in board_init_f(). Before board_init_f() > typically a lot of(in fact most of)

Re: [U-Boot] [PATCH v2 22/22] omap: spl: add more debug traces

2011-06-13 Thread Aneesh V
Dear Wolfgang, Heiko, On Monday 13 June 2011 07:29 PM, Aneesh V wrote: > Dear Wolfgang, [snip ...] > But this didn't work. It crashes at the first printf(). The reason is > init_baudrate() needs global data and global data is initialized in > board_init_f(). Further, we can not move global data in

Re: [U-Boot] [PATCH v2 22/22] omap: spl: add more debug traces

2011-06-13 Thread Aneesh V
Dear Wolfgang, I just realized that I had not responded to this message. On Monday 16 May 2011 01:51 AM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<1305472900-4004-23-git-send-email-ane...@ti.com> you wrote: >> In SPL console is enabled very early where as in U-Boot >> it's not. So, SP

Re: [U-Boot] [PATCH v2 22/22] omap: spl: add more debug traces

2011-05-15 Thread Wolfgang Denk
Dear Aneesh V, In message <1305472900-4004-23-git-send-email-ane...@ti.com> you wrote: > In SPL console is enabled very early where as in U-Boot > it's not. So, SPL can have traces in early init code Console should _always_ be enabled as early as possible, > while U-Boot can not have it in the s

[U-Boot] [PATCH v2 22/22] omap: spl: add more debug traces

2011-05-15 Thread Aneesh V
In SPL console is enabled very early where as in U-Boot it's not. So, SPL can have traces in early init code while U-Boot can not have it in the same shared code. Adding a debug print macro that will be defined in SPL but compiled out in U-Boot. Also add some useful debug traces throughout SPL S