subject:"\[U\-Boot\] \[PATCH v2 24\/37\] rockchip\: Tidy up the register\-access macros"

Re: [U-Boot] [PATCH v2 24/37] rockchip: Tidy up the register-access macros

2016-01-22 Thread Simon Glass

On 21 January 2016 at 19:45, Simon Glass wrote: > These work reasonable well, but there are a few errors: > > - Brackets should be used to avoid unexpected side-effects > - When setting bits, the corresponding upper 16 bits should be set also > > Signed-off-by: Simon Glass

[U-Boot] [PATCH v2 24/37] rockchip: Tidy up the register-access macros

2016-01-21 Thread Simon Glass

These work reasonable well, but there are a few errors: - Brackets should be used to avoid unexpected side-effects - When setting bits, the corresponding upper 16 bits should be set also Signed-off-by: Simon Glass --- Changes in v2: None