[U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-18 Thread Luca Ceresoli
With the upcoming TFTP server implementation, the remote node can be either a client or a server, so avoid ambiguities. Signed-off-by: Luca Ceresoli Cc: Wolfgang Denk --- Changes in v2: - fixed checkpatch issues. net/tftp.c | 42 +- 1 files changed, 2

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-19 Thread Detlev Zundel
Hi Luca, > With the upcoming TFTP server implementation, the remote node can be > either a client or a server, so avoid ambiguities. > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > --- > Changes in v2: > - fixed checkpatch issues. > > net/tftp.c | 42 +-

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-19 Thread Luca Ceresoli
Il 19/04/2011 16:18, Detlev Zundel ha scritto: > Hi Luca, > >> With the upcoming TFTP server implementation, the remote node can be >> either a client or a server, so avoid ambiguities. >> >> Signed-off-by: Luca Ceresoli >> Cc: Wolfgang Denk >> --- >> Changes in v2: >> - fixed checkpatch issues.

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-19 Thread Detlev Zundel
Hi Luca, [...] >> Whitespace fix. > > checkpatch again. Hm, I see. Still, can we have one commit (with "cosmetic" in the changelog) that silences checkpatch but does not have any functional changes? We really try hard to separate cosmetic from functional changes. This makes reviewing (and deb

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-19 Thread Luca Ceresoli
Hi, just a few e-mails ago along this thread Albert Aribaud wrote: > My opinion is that you should make sure that at least the code you touch > is checkpatch-clean, so yes, you should fix that; but there is no need > to submit 'checkpatch-compliance' patches. Just fix the line here so > that

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-20 Thread Detlev Zundel
Hi Luca, > Hi, > > just a few e-mails ago along this thread Albert Aribaud wrote: > >> My opinion is that you should make sure that at least the code you touch >> is checkpatch-clean, so yes, you should fix that; but there is no need >> to submit 'checkpatch-compliance' patches. Just fix the li

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-20 Thread Detlev Zundel
Hi Luca, > Il 19/04/2011 16:18, Detlev Zundel ha scritto: >> Hi Luca, >> >>> With the upcoming TFTP server implementation, the remote node can be >>> either a client or a server, so avoid ambiguities. >>> >>> Signed-off-by: Luca Ceresoli >>> Cc: Wolfgang Denk >>> --- >>> Changes in v2: >>> - fix

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-20 Thread Luca Ceresoli
Detlev Zundel wrote: > Hi Luca, > >> Il 19/04/2011 16:18, Detlev Zundel ha scritto: >>> Hi Luca, >>> With the upcoming TFTP server implementation, the remote node can be either a client or a server, so avoid ambiguities. Signed-off-by: Luca Ceresoli Cc: Wolfgang Denk -

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-04-29 Thread Mike Frysinger
On Monday, April 18, 2011 12:19:51 Luca Ceresoli wrote: > With the upcoming TFTP server implementation, the remote node can be > either a client or a server, so avoid ambiguities. the summary made me worried because i thought you were going to rename the env var "server" to "remote". could you t

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-04 Thread Luca Ceresoli
Detlev Zundel wrote: > > I'll start a new thread to discuss this. Hopefully we then come up with > a policy to stick into that wiki page. > Now that the checkpatch policy is much more clear, I started to clean up the networking stuff, on top of which the TFTP server sits. net/net.c alone counts

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-04 Thread Detlev Zundel
Hi Luca, > Detlev Zundel wrote: >> >> I'll start a new thread to discuss this. Hopefully we then come up with >> a policy to stick into that wiki page. >> > > Now that the checkpatch policy is much more clear, I started to clean up > the networking stuff, on top of which the TFTP server sits. Th

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-12 Thread Wolfgang Denk
Dear Luca Ceresoli, In message <1303143594-5345-4-git-send-email-luca.ceres...@comelit.it> you wrote: > With the upcoming TFTP server implementation, the remote node can be > either a client or a server, so avoid ambiguities. > > Signed-off-by: Luca Ceresoli > Cc: Wolfgang Denk > --- > Changes

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-13 Thread Luca Ceresoli
Hi Wolfgang, Wolfgang Denk wrote: > Dear Luca Ceresoli, > > In message<1303143594-5345-4-git-send-email-luca.ceres...@comelit.it> you > wrote: >> With the upcoming TFTP server implementation, the remote node can be >> either a client or a server, so avoid ambiguities. >> >> Signed-off-by: Luca C

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-14 Thread Luca Ceresoli
Luca Ceresoli wrote: > Hi Wolfgang, > > Wolfgang Denk wrote: >> Dear Luca Ceresoli, >> >> In >> message<1303143594-5345-4-git-send-email-luca.ceres...@comelit.it> >> you wrote: >>> With the upcoming TFTP server implementation, the remote node can be >>> either a client or a server, so avoid ambi

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-16 Thread Luca Ceresoli
Mike Frysinger wrote: > On Monday, April 18, 2011 12:19:51 Luca Ceresoli wrote: >> With the upcoming TFTP server implementation, the remote node can be >> either a client or a server, so avoid ambiguities. > the summary made me worried because i thought you were going to rename the env > var "serve

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-16 Thread Luca Ceresoli
Luca Ceresoli wrote: > Il 19/04/2011 16:18, Detlev Zundel ha scritto: >> Hi Luca, >> >>> With the upcoming TFTP server implementation, the remote node can be >>> either a client or a server, so avoid ambiguities. >>> >>> Signed-off-by: Luca Ceresoli >>> Cc: Wolfgang Denk >>> --- >>> Changes in v2:

Re: [U-Boot] [PATCH v2 3/6] TFTP: rename "server" to "remote"

2011-05-17 Thread Detlev Zundel
Hi Luca, [...] > I removed the checkpatch-related changes: they are now on the tftp > cleanup patch series that I submitted on saturday, and on top of which > v3 of the TFTP server will be based. Thanks for your persistence - it is very much appreciated! Detlev -- The proprietary-Unix player