Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-11 Thread Albert ARIBAUD
Hi Stephen, On Wed, 10 Apr 2013 17:09:45 -0600, Stephen Warren swar...@wwwdotorg.org wrote: On 04/10/2013 04:50 PM, Albert ARIBAUD wrote: On Wed, 10 Apr 2013 16:21:54 -0600, Stephen Warren wrote: On 04/09/2013 05:14 PM, Albert ARIBAUD wrote: ... This still seems to have separate defines

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-11 Thread Albert ARIBAUD
Hi Stephen, On Wed, 10 Apr 2013 17:16:49 -0600, Stephen Warren swar...@wwwdotorg.org wrote: On 04/10/2013 05:09 PM, Albert ARIBAUD wrote: On Thu, 11 Apr 2013 00:50:01 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: What we could do, though, is subdivide testing based on the

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-11 Thread Tom Rini
On Thu, Apr 11, 2013 at 04:32:53PM +0200, Albert ARIBAUD wrote: Hi Stephen, On Wed, 10 Apr 2013 17:16:49 -0600, Stephen Warren swar...@wwwdotorg.org wrote: On 04/10/2013 05:09 PM, Albert ARIBAUD wrote: On Thu, 11 Apr 2013 00:50:01 +0200, Albert ARIBAUD albert.u.b...@aribaud.net

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-11 Thread Stephen Warren
On 04/11/2013 10:08 AM, Tom Rini wrote: ... To be clear, I think the fake partitioning scheme we use when the case is we care about text/data/rodata/bss fitting in $X is not optimal, but it covers all of the cases without adding more complexity / another way to achieve the same ends. But it

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-11 Thread Albert ARIBAUD
Hi Stephen, On Wed, 10 Apr 2013 17:09:45 -0600, Stephen Warren swar...@wwwdotorg.org wrote: On 04/10/2013 04:50 PM, Albert ARIBAUD wrote: On Wed, 10 Apr 2013 16:21:54 -0600, Stephen Warren wrote: On 04/09/2013 05:14 PM, Albert ARIBAUD wrote: ... This still seems to have separate defines

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-10 Thread Stephen Warren
On 04/09/2013 05:14 PM, Albert ARIBAUD wrote: Remove SPL-related ASSERT() in arch/arm/cpu/u-boot.lds as this file is never used for SPL builds. Rewrite the ASSERT() in arch/arm/cpu/u-boot-spl.lds to separately test image (text,data,rodata...) size and BSS size each against its own max.

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-10 Thread Albert ARIBAUD
Hi Stephen, On Wed, 10 Apr 2013 16:21:54 -0600, Stephen Warren swar...@wwwdotorg.org wrote: On 04/09/2013 05:14 PM, Albert ARIBAUD wrote: Remove SPL-related ASSERT() in arch/arm/cpu/u-boot.lds as this file is never used for SPL builds. Rewrite the ASSERT() in

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-10 Thread Stephen Warren
On 04/10/2013 04:50 PM, Albert ARIBAUD wrote: On Wed, 10 Apr 2013 16:21:54 -0600, Stephen Warren wrote: On 04/09/2013 05:14 PM, Albert ARIBAUD wrote: ... This still seems to have separate defines for SPL text/data/rodata size and BSS size. If I want instead to limit the total

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-10 Thread Albert ARIBAUD
On Thu, 11 Apr 2013 00:50:01 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: What we could do, though, is subdivide testing based on the existence or non-existence of CONFIG_SPL_BSS_START_ADDR: - if CONFIG_SPL_BSS_START_ADDR exists, then we assume SPL image and BSS are disjoint and

Re: [U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-10 Thread Stephen Warren
On 04/10/2013 05:09 PM, Albert ARIBAUD wrote: On Thu, 11 Apr 2013 00:50:01 +0200, Albert ARIBAUD albert.u.b...@aribaud.net wrote: What we could do, though, is subdivide testing based on the existence or non-existence of CONFIG_SPL_BSS_START_ADDR: - if CONFIG_SPL_BSS_START_ADDR exists, then

[U-Boot] [PATCH v2 4/4] ARM: fix CONFIG_SPL_MAX_SIZE semantics

2013-04-09 Thread Albert ARIBAUD
Remove SPL-related ASSERT() in arch/arm/cpu/u-boot.lds as this file is never used for SPL builds. Rewrite the ASSERT() in arch/arm/cpu/u-boot-spl.lds to separately test image (text,data,rodata...) size and BSS size each against its own max. Also, output section mmutable is not used in SPL