Re: [U-Boot] [PATCH v2 4/9] dm: usb: Fix finding of first upstream usb-2 hub in the ehci dm code

2015-05-03 Thread Simon Glass
On 1 May 2015 at 04:04, Hans de Goede wrote: > The ehci driver model code for finding the first upstream usb-2 hub before > this commit has a number of issues: > > 1) "if (!ttdev->speed != USB_SPEED_HIGH)" does not work because the '!' >takes presedence over the '!=' this should simply be >

[U-Boot] [PATCH v2 4/9] dm: usb: Fix finding of first upstream usb-2 hub in the ehci dm code

2015-05-01 Thread Hans de Goede
The ehci driver model code for finding the first upstream usb-2 hub before this commit has a number of issues: 1) "if (!ttdev->speed != USB_SPEED_HIGH)" does not work because the '!' takes presedence over the '!=' this should simply be "if (ttdev->speed == USB_SPEED_HIGH)" 2) It makes ttdev