[U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-27 Thread Mark Jackson
This patch adds 16bpp BMP support to the common lcd code. Use CONFIG_BMP_16BPP and set LCD_BPP to LCD_COLOR16 to enable the code. At the moment it's only been tested on the MIMC200 AVR32 board, but extending this to other platforms should be a simple task !! Signed-off-by: Mark Jackson ---

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-02-23 Thread Haavard Skinnemoen
Mark Jackson wrote: > Haavard Skinnemoen wrote: > > Mark Jackson wrote: > >>> We do NOT want to do everything that is possible, but only what is > >>> reasonable. > >> Exactly ... otherwise where do you stop ? JPG, GIF, TIFF, PNG, etc ? > >> We're *only* meant to be showing a simply boot up

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-28 Thread Wolfgang Denk
Dear Mark Jackson, In message <497f1732.6050...@mimc.co.uk> you wrote: > This patch adds 16bpp BMP support to the common lcd code. > > Use CONFIG_BMP_16BPP and set LCD_BPP to LCD_COLOR16 to enable the code. > > At the moment it's only been tested on the MIMC200 AVR32 board, but extending > this

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-29 Thread Mark Jackson
Wolfgang Denk wrote: > Dear Mark Jackson, > > In message <497f1732.6050...@mimc.co.uk> you wrote: >> This patch adds 16bpp BMP support to the common lcd code. >> >> Use CONFIG_BMP_16BPP and set LCD_BPP to LCD_COLOR16 to enable the code. >> >> At the moment it's only been tested on the MIMC200 AVR3

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-29 Thread Wolfgang Denk
Dear Mark Jackson, In message <49817e75.7060...@mimc.co.uk> you wrote: > >> + bmap += (padded_line - width) * 2; > >> + fb -= (width * 2 + lcd_line_length); > > > > Is it intentional that you reverse padded_line and width here, i.e. > > you are sure it's not >

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-30 Thread Mark Jackson
Wolfgang Denk wrote: > Dear Mark Jackson, > > In message <49817e75.7060...@mimc.co.uk> you wrote: >> >> Or have I misunderstood the bmp format and the existing code ? > > I don't know - I'm just asking because the 16 bpp case is different > from the 1 and 8 bpp cases where the operands are swa

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-30 Thread Guennadi Liakhovetski
On Tue, 27 Jan 2009, Mark Jackson wrote: > This patch adds 16bpp BMP support to the common lcd code. > > Use CONFIG_BMP_16BPP and set LCD_BPP to LCD_COLOR16 to enable the code. > > At the moment it's only been tested on the MIMC200 AVR32 board, but extending > this to other platforms should be

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-30 Thread Wolfgang Denk
Dear Guennadi Liakhovetski, In message you wrote: > > platform-specific types and code. So, looking at this your patch - do we > really need the one more CONFIG_ define for CONFIG_BMP_16BPP? What are the > drawbacks of adding your code unconditionally? extra 100 bytes for all > configurations

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-01-30 Thread Guennadi Liakhovetski
On Fri, 30 Jan 2009, Wolfgang Denk wrote: > > If we really add more bmp formats, we also get more combinations like of > > bmp / lcd: > > Not necessarily. We can always request that bitmap images match the > "natural" color depth of the display. It makes no sense to send a 16 > bpp image to a 1

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-02-01 Thread Mark Jackson
Wolfgang Denk wrote: > Dear Guennadi Liakhovetski, > > In message you wrote: >> platform-specific types and code. So, looking at this your patch - do we >> really need the one more CONFIG_ define for CONFIG_BMP_16BPP? What are the >> drawbacks of adding your code unconditionally? extra 100 byte

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-02-02 Thread Haavard Skinnemoen
Mark Jackson wrote: > > We do NOT want to do everything that is possible, but only what is > > reasonable. > > Exactly ... otherwise where do you stop ? JPG, GIF, TIFF, PNG, etc ? > We're *only* meant to be showing a simply boot up image (not view lots > of different sized photos or movies !!

Re: [U-Boot] [PATCH v3] Add 16bpp BMP support

2009-02-02 Thread Mark Jackson
Haavard Skinnemoen wrote: > Mark Jackson wrote: >>> We do NOT want to do everything that is possible, but only what is >>> reasonable. >> Exactly ... otherwise where do you stop ? JPG, GIF, TIFF, PNG, etc ? >> We're *only* meant to be showing a simply boot up image (not view lots >> of differe