Re: [U-Boot] [PATCH v3] Add imls utility command

2009-04-06 Thread Marco Stornelli
Hi Wolfgang, 2009/4/5 Wolfgang Denk w...@denx.de: Dear Marco, In message 49d8e8f3.4010...@gmail.com you wrote: +  for (j = sectoroffset; j sectorcount; ++j) { i. e. add             if (lseek(fd, j*sectorsize, SEEK_SET) != j*sectorsize) {                     error handling goes

Re: [U-Boot] [PATCH v3] Add imls utility command

2009-04-05 Thread Marco
Hi Wolfgang, first of all thank you for your comments. Wolfgang Denk ha scritto: Dear Marco, In message 49d74e7b@gmail.com you wrote: Fixed a memory leak in image_verify_header function. Used the functions image_get_() from image.h. Fixed two sector boundary misalignment while

Re: [U-Boot] [PATCH v3] Add imls utility command

2009-04-05 Thread Wolfgang Denk
Dear Marco, In message 49d8e8f3.4010...@gmail.com you wrote: + for (j = sectoroffset; j sectorcount; ++j) { i. e. add if (lseek(fd, j*sectorsize, SEEK_SET) != j*sectorsize) { error handling goes here } Mmm...I don't well

[U-Boot] [PATCH v3] Add imls utility command

2009-04-04 Thread Marco
Fixed a memory leak in image_verify_header function. Used the functions image_get_() from image.h. Fixed two sector boundary misalignment while reading. Signed-off-by: Marco Stornelli marco.storne...@gmail.com --- diff -uprN u-boot-2009.03-orig/tools/imls.c u-boot-2009.03/tools/imls.c ---

Re: [U-Boot] [PATCH v3] Add imls utility command

2009-04-04 Thread Wolfgang Denk
Dear Marco, In message 49d74e7b@gmail.com you wrote: Fixed a memory leak in image_verify_header function. Used the functions image_get_() from image.h. Fixed two sector boundary misalignment while reading. ... + err = ioctl(fd, MEMGETINFO, mtdinfo); + if (err 0) { +