Re: [U-Boot] [PATCH v3] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

2012-07-05 Thread Albert ARIBAUD
Hi Tom, On Thu, 5 Jul 2012 09:18:28 -0700, Tom Rini wrote: > On Thu, Jul 05, 2012 at 01:57:26PM +0200, Albert ARIBAUD wrote: > > Hi Tetsuyuki, > > > > On Fri, 29 Jun 2012 18:36:21 +0900, Tetsuyuki Kobayashi > > wrote: > > > save_boot_params_default() in cpu.c accesses uninitialized stack area >

Re: [U-Boot] [PATCH v3] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

2012-07-05 Thread Tom Rini
On Thu, Jul 05, 2012 at 01:57:26PM +0200, Albert ARIBAUD wrote: > Hi Tetsuyuki, > > On Fri, 29 Jun 2012 18:36:21 +0900, Tetsuyuki Kobayashi > wrote: > > save_boot_params_default() in cpu.c accesses uninitialized stack area > > when it compiled with -O0 (not optimized). > > > > Signed-off-by: Tet

Re: [U-Boot] [PATCH v3] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

2012-07-05 Thread Albert ARIBAUD
Hi Tetsuyuki, On Fri, 29 Jun 2012 18:36:21 +0900, Tetsuyuki Kobayashi wrote: > save_boot_params_default() in cpu.c accesses uninitialized stack area > when it compiled with -O0 (not optimized). > > Signed-off-by: Tetsuyuki Kobayashi > --- > Changes for v2: > - include and use __naked instead

Re: [U-Boot] [PATCH v3] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

2012-07-05 Thread Albert ARIBAUD
Hi Tetsuyuki, Tom, On Fri, 29 Jun 2012 07:21:57 -0700, Tom Rini wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 06/29/2012 02:36 AM, Tetsuyuki Kobayashi wrote: > > save_boot_params_default() in cpu.c accesses uninitialized stack > > area when it compiled with -O0 (not optimized).

Re: [U-Boot] [PATCH v3] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

2012-06-29 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 06/29/2012 02:36 AM, Tetsuyuki Kobayashi wrote: > save_boot_params_default() in cpu.c accesses uninitialized stack > area when it compiled with -O0 (not optimized). > > Signed-off-by: Tetsuyuki Kobayashi Acked-by: Tom Rini - -- Tom -BEGIN

[U-Boot] [PATCH v3] arm: bugfix: save_boot_params_default accesses uninitalized stack when -O0

2012-06-29 Thread Tetsuyuki Kobayashi
save_boot_params_default() in cpu.c accesses uninitialized stack area when it compiled with -O0 (not optimized). Signed-off-by: Tetsuyuki Kobayashi --- Changes for v2: - include and use __naked instead of __attribute__((naked)) Changes for v3: - move __naked after void - reformat comments