Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-22 Thread Lukasz Majewski
Hi Heiko, > Hello Lukasz, > > Am 16.05.2014 10:58, schrieb Lukasz Majewski: > > Hi Wolfgang, Tom, > > > >> Hi Wolfgang, > >> > >>> Dear Lukasz, > >>> > >>> In message<20140515090904.32f1d13d@amdc2363> you wrote: > > >> What I complained about is the change in behaviour. I asked > >

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-20 Thread Lukasz Majewski
Hi Heiko, > > Hello Lukasz, > > Am 16.05.2014 10:58, schrieb Lukasz Majewski: > > Hi Wolfgang, Tom, > > > >> Hi Wolfgang, > >> > >>> Dear Lukasz, > >>> > >>> In message<20140515090904.32f1d13d@amdc2363> you wrote: > > >> What I complained about is the change in behaviour. I asked > >>

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-19 Thread Heiko Schocher
Hello Lukasz, Am 16.05.2014 10:58, schrieb Lukasz Majewski: Hi Wolfgang, Tom, Hi Wolfgang, Dear Lukasz, In message<20140515090904.32f1d13d@amdc2363> you wrote: What I complained about is the change in behaviour. I asked to make the existing behaviour the default, so unaware users will

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-16 Thread Lukasz Majewski
Hi Wolfgang, Tom, > Hi Wolfgang, > > > Dear Lukasz, > > > > In message <20140515090904.32f1d13d@amdc2363> you wrote: > > > > > > > > What I complained about is the change in behaviour. I asked > > > > > to make the existing behaviour the default, so unaware users > > > > > will not be affected

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-15 Thread Lukasz Majewski
Hi Wolfgang, > Dear Lukasz, > > In message <20140515154334.626923b4@amdc2363> you wrote: > > > > > This reinforces my speculation that you are actually addressing > > > the wrong problem. Instead of adding new code and environment > > > variables and making the system even more complex, we shou

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-15 Thread Wolfgang Denk
Dear Lukasz, In message <20140515154334.626923b4@amdc2363> you wrote: > > > This reinforces my speculation that you are actually addressing the > > wrong problem. Instead of adding new code and environment variables > > and making the system even more complex, we should just leave > > everything

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-15 Thread Lukasz Majewski
Hi Wolfgang, > Dear Lukasz, > > In message <20140515090904.32f1d13d@amdc2363> you wrote: > > > > > > What I complained about is the change in behaviour. I asked to > > > > make the existing behaviour the default, so unaware users will > > > > not be affected. Only if you intentionally want some

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-15 Thread Wolfgang Denk
Dear Lukasz, In message <20140515090904.32f1d13d@amdc2363> you wrote: > > > > What I complained about is the change in behaviour. I asked to make > > > the existing behaviour the default, so unaware users will not be > > > affected. Only if you intentionally want some other behaviour you > > > c

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-15 Thread Heiko Schocher
Hello Lukasz, Sorry for answering so late to this thread ... Am 15.05.2014 09:09, schrieb Lukasz Majewski: Hi Tom, Wolfgang, On Fri, May 09, 2014 at 10:31:54AM +0200, Wolfgang Denk wrote: Dear Lukasz, In message<20140509085203.31133238@amdc2363> you wrote: For automated tests I use MD5 a

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-15 Thread Lukasz Majewski
Hi Tom, Wolfgang, > On Fri, May 09, 2014 at 10:31:54AM +0200, Wolfgang Denk wrote: > > Dear Lukasz, > > > > In message <20140509085203.31133238@amdc2363> you wrote: > > > > > > For automated tests I use MD5 and compare this value before > > > sending data to target via DFU and after I read it. T

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-12 Thread Tom Rini
On Fri, May 09, 2014 at 10:31:54AM +0200, Wolfgang Denk wrote: > Dear Lukasz, > > In message <20140509085203.31133238@amdc2363> you wrote: > > > > For automated tests I use MD5 and compare this value before sending > > data to target via DFU and after I read it. This testing is done purely > > on

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-09 Thread Lukasz Majewski
Hi Wolfgang, > Dear Lukasz, > > In message <20140509085203.31133238@amdc2363> you wrote: > > > > For automated tests I use MD5 and compare this value before sending > > data to target via DFU and after I read it. This testing is done > > purely on HOST machine. > > This is unsufficient. You sh

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-09 Thread Wolfgang Denk
Dear Lukasz, In message <20140509085203.31133238@amdc2363> you wrote: > > For automated tests I use MD5 and compare this value before sending > data to target via DFU and after I read it. This testing is done purely > on HOST machine. This is unsufficient. You should always verify the image on

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-08 Thread Lukasz Majewski
Hi Wolfgang, > Dear Lukasz Majewski, > > In message <1399552067-31208-1-git-send-email-l.majew...@samsung.com> > you wrote: > > Up till now the CRC32 of received data was calculated > > unconditionally. The standard crc32 implementation causes long > > delay when large images were uploaded. > >

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-08 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <1399552067-31208-1-git-send-email-l.majew...@samsung.com> you wrote: > Up till now the CRC32 of received data was calculated unconditionally. > The standard crc32 implementation causes long delay when large images > were uploaded. > > The "dfu_hash_algo" environm

Re: [U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-08 Thread Marek Vasut
On Thursday, May 08, 2014 at 02:27:47 PM, Lukasz Majewski wrote: > Up till now the CRC32 of received data was calculated unconditionally. > The standard crc32 implementation causes long delay when large images > were uploaded. > > The "dfu_hash_algo" environment variable gives the opportunity to >

[U-Boot] [PATCH v3] dfu: Introduction of the "dfu_hash_algo" env variable for checksum method setting

2014-05-08 Thread Lukasz Majewski
Up till now the CRC32 of received data was calculated unconditionally. The standard crc32 implementation causes long delay when large images were uploaded. The "dfu_hash_algo" environment variable gives the opportunity to enable on demand (when e.g. debugging) the hash (crc32) calculation. It can