Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-26 Thread Simon Glass
On 25 November 2015 at 09:51, Simon Glass wrote: > Hi, > > On 24 November 2015 at 23:44, Bin Meng wrote: >> On Wed, Nov 25, 2015 at 11:20 AM, Thomas Chou wrote: >>> Hi Simon, >>> >>> On 2015年11月25日 02:23, Simon Glass wrote: Please try u-boot-dm/testing. This seems to be a differen

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-25 Thread Simon Glass
Hi, On 24 November 2015 at 23:44, Bin Meng wrote: > On Wed, Nov 25, 2015 at 11:20 AM, Thomas Chou wrote: >> Hi Simon, >> >> On 2015年11月25日 02:23, Simon Glass wrote: >>> >>> >>> Please try u-boot-dm/testing. This seems to be a different problem: >>> >>> avr32: + grasshopper >>> +lib/time

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Bin Meng
On Wed, Nov 25, 2015 at 11:20 AM, Thomas Chou wrote: > Hi Simon, > > On 2015年11月25日 02:23, Simon Glass wrote: >> >> >> Please try u-boot-dm/testing. This seems to be a different problem: >> >> avr32: + grasshopper >> +lib/time.c:20: warning: register used for two global register variables

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Thomas Chou
Hi Simon, On 2015年11月25日 02:23, Simon Glass wrote: Please try u-boot-dm/testing. This seems to be a different problem: avr32: + grasshopper +lib/time.c:20: warning: register used for two global register variables I am using the avr32 toolchain from kernel.org, and couldn't see the

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Bin Meng
Hi Simon, On Wed, Nov 25, 2015 at 4:31 AM, Simon Glass wrote: > From: Bin Meng > > There are timers with a 64-bit counter value but current timer > uclass driver assumes a 32-bit one. Modify timer_get_count() > to ask timer driver to always return a 64-bit counter value, > and provide an inline

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Simon Glass
Hi, On 24 November 2015 at 11:23, Simon Glass wrote: > Hi Thomas, > > On 24 November 2015 at 07:01, Thomas Chou wrote: >> Hi Simon, >> >> On 2015年11月24日 18:09, Simon Glass wrote: >>> >>> >>> Unfortunately this causes build errors for a few avr32 boards - e.g. >>> grasshopper. >>> >>> I think the

[U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Simon Glass
From: Bin Meng There are timers with a 64-bit counter value but current timer uclass driver assumes a 32-bit one. Modify timer_get_count() to ask timer driver to always return a 64-bit counter value, and provide an inline helper function timer_conv_64() to handle the 32-bit/64-bit conversion auto

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Simon Glass
Hi Thomas, On 24 November 2015 at 07:01, Thomas Chou wrote: > Hi Simon, > > On 2015年11月24日 18:09, Simon Glass wrote: >> >> >> Unfortunately this causes build errors for a few avr32 boards - e.g. >> grasshopper. >> >> I think the problem is the gd declaration in the timer.h header file. >> I don't

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Thomas Chou
Hi Simon, On 2015年11月24日 18:09, Simon Glass wrote: Unfortunately this causes build errors for a few avr32 boards - e.g. grasshopper. I think the problem is the gd declaration in the timer.h header file. I don't think that is a good idea. Can we move it to the C file? If you meant, "warning:

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-24 Thread Simon Glass
Hi, On 22 November 2015 at 09:21, Simon Glass wrote: > Hi, > > On 20 November 2015 at 17:41, Thomas Chou wrote: >> Hi Simon, >> >> >> On 2015年11月21日 05:10, Simon Glass wrote: >> >> @@ -35,10 +52,10 @@ struct timer_ops { >> * Get the current timer count >> * >>

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-23 Thread Simon Glass
Applied to u-boot-dm, thanks! ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-22 Thread Simon Glass
Hi, On 20 November 2015 at 17:41, Thomas Chou wrote: > Hi Simon, > > > On 2015年11月21日 05:10, Simon Glass wrote: > > @@ -35,10 +52,10 @@ struct timer_ops { > * Get the current timer count > * > * @dev: The timer device > -* @count: poin

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-20 Thread Thomas Chou
Hi Simon, On 2015年11月21日 05:10, Simon Glass wrote: @@ -35,10 +52,10 @@ struct timer_ops { * Get the current timer count * * @dev: The timer device -* @count: pointer that returns the current timer count +* @count: pointer that returns the current 64-

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-20 Thread Simon Glass
Hi Bin, On 15 November 2015 at 19:19, Bin Meng wrote: > Hi Simon, > > On Sat, Nov 14, 2015 at 10:04 AM, Simon Glass wrote: >> Hi Bin, >> >> On 13 November 2015 at 01:11, Bin Meng wrote: >>> There are timers with a 64-bit counter value but current timer >>> uclass driver assumes a 32-bit one. Mo

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-15 Thread Bin Meng
Hi Simon, On Sat, Nov 14, 2015 at 10:04 AM, Simon Glass wrote: > Hi Bin, > > On 13 November 2015 at 01:11, Bin Meng wrote: >> There are timers with a 64-bit counter value but current timer >> uclass driver assumes a 32-bit one. Modify timer_get_count() >> to ask timer driver to always return a 6

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-15 Thread Bin Meng
Hi Simon, On Sat, Nov 14, 2015 at 10:04 AM, Simon Glass wrote: > Hi Bin, > > On 13 November 2015 at 01:11, Bin Meng wrote: >> There are timers with a 64-bit counter value but current timer >> uclass driver assumes a 32-bit one. Modify timer_get_count() >> to ask timer driver to always return a 6

Re: [U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-13 Thread Simon Glass
Hi Bin, On 13 November 2015 at 01:11, Bin Meng wrote: > There are timers with a 64-bit counter value but current timer > uclass driver assumes a 32-bit one. Modify timer_get_count() > to ask timer driver to always return a 64-bit counter value, > and provide an inline helper function timer_conv_6

[U-Boot] [PATCH v3 05/11] dm: timer: Support 64-bit counter

2015-11-13 Thread Bin Meng
There are timers with a 64-bit counter value but current timer uclass driver assumes a 32-bit one. Modify timer_get_count() to ask timer driver to always return a 64-bit counter value, and provide an inline helper function timer_conv_64() to handle the 32-bit/64-bit conversion automatically. Signe