[U-Boot] [PATCH v3 081/108] spi: ich: Add mmio_base to struct ich_spi_platdata

2019-10-20 Thread Simon Glass
It is useful to store the mmio base in platdata. It reduces the amount of casting needed. Update the code and move the struct to the C file at the same time, as we will need to use with of-platdata. Signed-off-by: Simon Glass --- Changes in v3: None Changes in v2: None drivers/spi/ich.c | 27 +

Re: [U-Boot] [PATCH v3 081/108] spi: ich: Add mmio_base to struct ich_spi_platdata

2019-11-19 Thread Bin Meng
Hi Simon, On Mon, Oct 21, 2019 at 11:40 AM Simon Glass wrote: > > It is useful to store the mmio base in platdata. It reduces the amount of > casting needed. Update the code and move the struct to the C file at the > same time, as we will need to use with of-platdata. > > Signed-off-by: Simon Gla

Re: [U-Boot] [PATCH v3 081/108] spi: ich: Add mmio_base to struct ich_spi_platdata

2019-11-19 Thread Simon Glass
Hi Bin, On Tue, 19 Nov 2019 at 06:36, Bin Meng wrote: > > Hi Simon, > > On Mon, Oct 21, 2019 at 11:40 AM Simon Glass wrote: > > > > It is useful to store the mmio base in platdata. It reduces the amount of > > casting needed. Update the code and move the struct to the C file at the > > same time

Re: [U-Boot] [PATCH v3 081/108] spi: ich: Add mmio_base to struct ich_spi_platdata

2019-11-20 Thread Bin Meng
Hi Simon, On Wed, Nov 20, 2019 at 1:53 AM Simon Glass wrote: > > Hi Bin, > > On Tue, 19 Nov 2019 at 06:36, Bin Meng wrote: > > > > Hi Simon, > > > > On Mon, Oct 21, 2019 at 11:40 AM Simon Glass wrote: > > > > > > It is useful to store the mmio base in platdata. It reduces the amount of > > > ca

Re: [U-Boot] [PATCH v3 081/108] spi: ich: Add mmio_base to struct ich_spi_platdata

2019-11-21 Thread Simon Glass
Hi Bin, On Wed, 20 Nov 2019 at 05:52, Bin Meng wrote: > > Hi Simon, > > On Wed, Nov 20, 2019 at 1:53 AM Simon Glass wrote: > > > > Hi Bin, > > > > On Tue, 19 Nov 2019 at 06:36, Bin Meng wrote: > > > > > > Hi Simon, > > > > > > On Mon, Oct 21, 2019 at 11:40 AM Simon Glass wrote: > > > > > > > >