Re: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-22 Thread Simon Glass
Hi Tom, On Aug 22, 2014 3:54 PM, "Tom Rini" wrote: > > On Fri, Aug 22, 2014 at 05:38:59PM -0400, Tom Rini wrote: > > On Fri, Aug 22, 2014 at 02:17:53PM -0600, Simon Glass wrote: > > > Hi Bryan, > > > > > > On 15 August 2014 17:51, Bryan Wu wrote: > > > > > > > > Commit b3dd64f5d537 "bootm: use g

Re: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-22 Thread Tom Rini
On Fri, Aug 22, 2014 at 05:38:59PM -0400, Tom Rini wrote: > On Fri, Aug 22, 2014 at 02:17:53PM -0600, Simon Glass wrote: > > Hi Bryan, > > > > On 15 August 2014 17:51, Bryan Wu wrote: > > > > > > Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced > > > a bug for booting FIT imag

Re: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-22 Thread Tom Rini
On Fri, Aug 22, 2014 at 02:17:53PM -0600, Simon Glass wrote: > Hi Bryan, > > On 15 August 2014 17:51, Bryan Wu wrote: > > > > Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced > > a bug for booting FIT image. It's because calling fit_parse_config() > > twice will give us wrong

Re: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-22 Thread Simon Glass
Hi Bryan, On 15 August 2014 17:51, Bryan Wu wrote: > > Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced > a bug for booting FIT image. It's because calling fit_parse_config() > twice will give us wrong value in img_addr. > > Add a new function genimg_get_kernel_addr_fit() whic

Re: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-20 Thread Simon Glass
Hi Bryan, On 20 August 2014 11:24, Bryan Wu wrote: > Hi Simon, Tom and Stephen, > > Could you guys review this patch which solved the issue York reported? > Sorry, busy week, will get to it soon though. Regards, Simon ___ U-Boot mailing list U-Boot@l

Re: [U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-20 Thread Bryan Wu
Hi Simon, Tom and Stephen, Could you guys review this patch which solved the issue York reported? Thanks, -Bryan On Fri, Aug 15, 2014 at 4:51 PM, Bryan Wu wrote: > Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced > a bug for booting FIT image. It's because calling fit_parse_

[U-Boot] [PATCH v3 1/2] image: fix bootm failure for FIT image

2014-08-15 Thread Bryan Wu
Commit b3dd64f5d537 "bootm: use genimg_get_kernel_addr()" introduced a bug for booting FIT image. It's because calling fit_parse_config() twice will give us wrong value in img_addr. Add a new function genimg_get_kernel_addr_fit() whichl will always return fit_uname_config and fit_uname_kernel for