Re: [U-Boot] [PATCH v3 1/3] mmc: sdhci: add the quirk for broken R1b response

2012-04-12 Thread Jaehoon Chung
Hi Terry. You're right. I sent the patch-v5..did you check them? Best Regards, Jaehoon Chung On 04/13/2012 05:21 AM, Terry Lambert wrote: > Sorry for not properly threading, just joined the list formally. > > inre: the subject, already replied to the author directly, but the > following comment

Re: [U-Boot] [PATCH v3 1/3] mmc: sdhci: add the quirk for broken R1b response

2012-04-12 Thread Terry Lambert
Sorry for not properly threading, just joined the list formally. inre: the subject, already replied to the author directly, but the following comments: The 'retriy' is post-decremented so the failure compare should be for -1. The word 'status' is misspelled as 'stauts". Other than that, LGTM wh

[U-Boot] [PATCH v3 1/3] mmc: sdhci: add the quirk for broken R1b response

2012-04-09 Thread Jaehoon Chung
When response type is R1b, mask value is added the SDHCI_INT_DAT_END. but in while(), didn't check that flag. So sdhci controller didn't work fine. CMD6 didn't always complete. So add the quirks for broken r1b response and add the timeout value to prevent the infinite loop. Signed-off-by: Jaehoon