Re: [U-Boot] [PATCH v3 12/14] pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

2018-09-13 Thread Otavio Salvador
On Thu, Sep 13, 2018 at 6:49 PM Fabio Estevam wrote: > > On Thu, Sep 13, 2018 at 6:33 PM, Otavio Salvador > wrote: > > On Thu, Sep 13, 2018 at 5:14 PM Fabio Estevam wrote: > >> > > ... > >> I see that CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is > >> already included in this

Re: [U-Boot] [PATCH v3 12/14] pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

2018-09-13 Thread Fabio Estevam
On Thu, Sep 13, 2018 at 6:33 PM, Otavio Salvador wrote: > On Thu, Sep 13, 2018 at 5:14 PM Fabio Estevam wrote: >> > ... >> I see that CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is >> already included in this file, so the change looks good, but the >> commit message needs to be

Re: [U-Boot] [PATCH v3 12/14] pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

2018-09-13 Thread Otavio Salvador
On Thu, Sep 13, 2018 at 5:14 PM Fabio Estevam wrote: > ... > I see that CONFIG_FSL_USDHC is defined inside "mx6_common.h", which is > already included in this file, so the change looks good, but the > commit message needs to be reworked. Like: pico-imx6ul: Remove CONFIG_FSL_USDHC from .h The

Re: [U-Boot] [PATCH v3 12/14] pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

2018-09-13 Thread Fabio Estevam
Hi Otavio, On Thu, Sep 13, 2018 at 4:57 PM, Otavio Salvador wrote: > The FSL_USDHC support is now handled by Kconfig and it is enabled on > the respective `defconfig` so the setting in .h is pointless. Just checked and I don't see FSL_USDHC option in Kconfig. > Signed-off-by: Otavio Salvador

[U-Boot] [PATCH v3 12/14] pico-imx6ul: Remove CONFIG_FSL_USDHC from .h

2018-09-13 Thread Otavio Salvador
The FSL_USDHC support is now handled by Kconfig and it is enabled on the respective `defconfig` so the setting in .h is pointless. Signed-off-by: Otavio Salvador --- Changes in v3: None Changes in v2: None include/configs/pico-imx6ul.h | 1 - 1 file changed, 1 deletion(-) diff --git