Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-19 Thread Simon Glass
Hi Eric, On Wed, Oct 17, 2012 at 6:07 PM, Eric Nelson wrote: > Hi Simon, > > > On 10/17/2012 05:50 PM, Simon Glass wrote: >> >> Hi Eric, >> >> On Wed, Oct 17, 2012 at 5:41 PM, Eric Nelson >> wrote: >>> >>> Hi Simon, >>> >>> >>> On 10/17/2012 03:07 PM, Simon Glass wrote: Hi Eric,

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-17 Thread Eric Nelson
Hi Simon, On 10/17/2012 05:50 PM, Simon Glass wrote: Hi Eric, On Wed, Oct 17, 2012 at 5:41 PM, Eric Nelson wrote: Hi Simon, On 10/17/2012 03:07 PM, Simon Glass wrote: Hi Eric, On Wed, Oct 17, 2012 at 8:34 AM, Eric Nelson wrote: On 10/17/2012 03:38 AM, Lukasz Majewski wrote:

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-17 Thread Simon Glass
Hi Eric, On Wed, Oct 17, 2012 at 5:41 PM, Eric Nelson wrote: > Hi Simon, > > > On 10/17/2012 03:07 PM, Simon Glass wrote: >> >> Hi Eric, >> >> On Wed, Oct 17, 2012 at 8:34 AM, Eric Nelson >> wrote: >>> >>> On 10/17/2012 03:38 AM, Lukasz Majewski wrote: > Certainly

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-17 Thread Eric Nelson
Hi Simon, On 10/17/2012 03:07 PM, Simon Glass wrote: Hi Eric, On Wed, Oct 17, 2012 at 8:34 AM, Eric Nelson wrote: On 10/17/2012 03:38 AM, Lukasz Majewski wrote: Certainly we could make the flushing more fine grained. My reasons for not (so far) are: 1. It is simpler to flush everything

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-17 Thread Simon Glass
Hi Eric, On Wed, Oct 17, 2012 at 8:34 AM, Eric Nelson wrote: > On 10/17/2012 03:38 AM, Lukasz Majewski wrote: >> >> Hi Simon, >> >>> Hi, >>> >>> On Thu, Aug 9, 2012 at 12:43 AM, Lukasz Majewski >>> wrote: Hi Simon, > This provides an option for the LCD to flush the dcache aft

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-17 Thread Eric Nelson
On 10/17/2012 03:38 AM, Lukasz Majewski wrote: Hi Simon, Hi, On Thu, Aug 9, 2012 at 12:43 AM, Lukasz Majewski wrote: Hi Simon, This provides an option for the LCD to flush the dcache after each update (puts, scroll or clear). Signed-off-by: Simon Glass --- Changes in v2: - Put the LCD ca

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-17 Thread Lukasz Majewski
Hi Simon, > Hi, > > On Thu, Aug 9, 2012 at 12:43 AM, Lukasz Majewski > wrote: > > Hi Simon, > > > >> This provides an option for the LCD to flush the dcache after each > >> update (puts, scroll or clear). > >> > >> Signed-off-by: Simon Glass > >> --- > >> Changes in v2: > >> - Put the LCD cache

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-10-16 Thread Simon Glass
Hi, On Thu, Aug 9, 2012 at 12:43 AM, Lukasz Majewski wrote: > Hi Simon, > >> This provides an option for the LCD to flush the dcache after each >> update (puts, scroll or clear). >> >> Signed-off-by: Simon Glass >> --- >> Changes in v2: >> - Put the LCD cache flush logic into lcd_putc() instead

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-08-09 Thread Lukasz Majewski
Hi Simon, > This provides an option for the LCD to flush the dcache after each > update (puts, scroll or clear). > > Signed-off-by: Simon Glass > --- > Changes in v2: > - Put the LCD cache flush logic into lcd_putc() instead of lcd_puts() > > Changes in v3: > - Put the LCD cache flush logic bac

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-07-19 Thread Mike Frysinger
On Thursday 12 July 2012 11:25:13 Simon Glass wrote: > +void lcd_sync(void) > +{ > + /* > + * flush_dcache_range() is declared in common.h but it seems that some > + * architectures do not actually implement it. Is there a way to find > + * out whether it exists? For now, ARM is

Re: [U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-07-19 Thread Mike Frysinger
On Thursday 12 July 2012 11:25:13 Simon Glass wrote: > --- a/common/lcd.c > +++ b/common/lcd.c > > +/* Flush LCD activity to the caches */ > +void lcd_sync(void) > +{ > + /* > + * flush_dcache_range() is declared in common.h but it seems that some > + * architectures do not actually

[U-Boot] [PATCH v3 13/18] lcd: Add support for flushing LCD fb from dcache after update

2012-07-12 Thread Simon Glass
This provides an option for the LCD to flush the dcache after each update (puts, scroll or clear). Signed-off-by: Simon Glass --- Changes in v2: - Put the LCD cache flush logic into lcd_putc() instead of lcd_puts() Changes in v3: - Put the LCD cache flush logic back into lcd_puts() common/lcd.