Re: [U-Boot] [PATCH v3 2/3] cfi_flash: convert to driver model

2015-11-02 Thread Stefan Roese
Hi Thomas, On 03.11.2015 07:25, Thomas Chou wrote: On 2015年11月03日 13:56, Stefan Roese wrote: if (CONFIG_IS_ENABLED(CFI_FLASH)) { struct udevice *dev; cfi_flash_num_flash_banks = 0; /* probe every MTD device to find cfi-flash device */ for (uclass_first_device(UCLASS_MTD, &de

Re: [U-Boot] [PATCH v3 2/3] cfi_flash: convert to driver model

2015-11-02 Thread Thomas Chou
Hi Stefan, On 2015年11月03日 13:56, Stefan Roese wrote: if (CONFIG_IS_ENABLED(CFI_FLASH)) { struct udevice *dev; cfi_flash_num_flash_banks = 0; /* probe every MTD device to find cfi-flash device */ for (uclass_first_device(UCLASS_MTD, &dev); dev; uclass_next_

Re: [U-Boot] [PATCH v3 2/3] cfi_flash: convert to driver model

2015-11-02 Thread Stefan Roese
Hi Thomas, On 03.11.2015 01:23, Thomas Chou wrote: #ifdef CONFIG_SYS_FLASH_PROTECTION /* read environment from EEPROM */ @@ -2322,6 +2337,14 @@ unsigned long flash_init (void) getenv_f("unlock", s, sizeof(s)); #endif +#ifdef CONFIG_CFI_FLASH /* for driver model */ +cfi_f

Re: [U-Boot] [PATCH v3 2/3] cfi_flash: convert to driver model

2015-11-02 Thread Thomas Chou
Hi Stefan, On 2015年11月02日 16:20, Stefan Roese wrote: @@ -2315,6 +2329,7 @@ unsigned long flash_init (void) { unsigned long size = 0; int i; + struct udevice *dev; I'm seeing this warning while compiling for some powerpc boards (e.g. canyonlands): drivers/mtd/cfi_flash

Re: [U-Boot] [PATCH v3 2/3] cfi_flash: convert to driver model

2015-11-02 Thread Stefan Roese
Hi Thomas, On 30.10.2015 14:33, Thomas Chou wrote: > Convert cfi flash to driver model. > > Signed-off-by: Thomas Chou > --- > v2 >add dts binding. >add more help to Kconfig. >move struct platdata to top of file as Simon suggested. > v3 >change to MTD uclass. > > doc/device-tr

[U-Boot] [PATCH v3 2/3] cfi_flash: convert to driver model

2015-10-30 Thread Thomas Chou
Convert cfi flash to driver model. Signed-off-by: Thomas Chou --- v2 add dts binding. add more help to Kconfig. move struct platdata to top of file as Simon suggested. v3 change to MTD uclass. doc/device-tree-bindings/mtd/mtd-physmap.txt | 88 drivers/mtd/Kc