Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2016-01-05 Thread Wills Wang
On 01/06/2016 08:25 AM, Simon Glass wrote: Hi WIlls, On 24 December 2015 at 04:22, Wills Wang wrote: Signed-off-by: Wills Wang --- Changes in v3: None Changes in v2: None drivers/serial/Makefile| 1 + drivers/serial/serial_ar933x.c | 274 ++

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2016-01-05 Thread Simon Glass
Hi WIlls, On 24 December 2015 at 04:22, Wills Wang wrote: > Signed-off-by: Wills Wang > --- > > Changes in v3: None > Changes in v2: None > > drivers/serial/Makefile| 1 + > drivers/serial/serial_ar933x.c | 274 > + > 2 files changed, 275 inser

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Thomas Chou
On 2015年12月25日 14:05, Wills Wang wrote: On 12/25/2015 10:39 AM, Thomas Chou wrote: Hi Wills, Is there any reason that you need to support pre-DM serial driver? It should be safe to support DM only. You may add debug_uart support which might be helpful during debug. The ops for DM serial is

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Wills Wang
On 12/25/2015 10:39 AM, Thomas Chou wrote: Hi Wills, Is there any reason that you need to support pre-DM serial driver? It should be safe to support DM only. You may add debug_uart support which might be helpful during debug. The ops for DM serial is different to pre-DM though the name look

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Thomas Chou
Hi Wills, There is code to set baud rate in Linux kernel, drivers/tty/serial/ar933x_uart.c Best regards, Thomas ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Thomas Chou
Hi Wills, Is there any reason that you need to support pre-DM serial driver? It should be safe to support DM only. You may add debug_uart support which might be helpful during debug. The ops for DM serial is different to pre-DM though the name look similar. Please see the comments below. I w

[U-Boot] [PATCH v3 2/4] mips: ath79: add serial driver for ar933x SOC

2015-12-24 Thread Wills Wang
Signed-off-by: Wills Wang --- Changes in v3: None Changes in v2: None drivers/serial/Makefile| 1 + drivers/serial/serial_ar933x.c | 274 + 2 files changed, 275 insertions(+) create mode 100644 drivers/serial/serial_ar933x.c diff --git a/drive