Re: [U-Boot] [PATCH v3 2/6] fat: write: fix broken write at non-zero file offset

2019-11-27 Thread Marek Szyprowski
Hi On 27.11.2019 04:13, AKASHI Takahiro wrote: > # I still need to understand the issues reported here. > > On Tue, Nov 26, 2019 at 11:57:34AM -0500, Tom Rini wrote: >> On Tue, Nov 26, 2019 at 09:15:08AM +0100, Marek Szyprowski wrote: >> >>> Handling of the start file offset was broken in the curr

Re: [U-Boot] [PATCH v3 2/6] fat: write: fix broken write at non-zero file offset

2019-11-26 Thread AKASHI Takahiro
# I still need to understand the issues reported here. On Tue, Nov 26, 2019 at 11:57:34AM -0500, Tom Rini wrote: > On Tue, Nov 26, 2019 at 09:15:08AM +0100, Marek Szyprowski wrote: > > > Handling of the start file offset was broken in the current code. Although > > the code skipped the needed clu

Re: [U-Boot] [PATCH v3 2/6] fat: write: fix broken write at non-zero file offset

2019-11-26 Thread Tom Rini
On Tue, Nov 26, 2019 at 09:15:08AM +0100, Marek Szyprowski wrote: > Handling of the start file offset was broken in the current code. Although > the code skipped the needed clusters, it then tried to continue write with > current cluster set to EOF, what caused assertion. It also lacked adjusting

[U-Boot] [PATCH v3 2/6] fat: write: fix broken write at non-zero file offset

2019-11-26 Thread Marek Szyprowski
Handling of the start file offset was broken in the current code. Although the code skipped the needed clusters, it then tried to continue write with current cluster set to EOF, what caused assertion. It also lacked adjusting filesize in case of writing at the end of file and adjusting in-cluster o