Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-28 Thread David Wu
Hi Philipp, 在 2018/12/27 下午10:31, Philipp Tomsich 写道: David, On 27.12.2018, at 13:49, David Wu wrote: Hi Christoph, I once submitted a series of patches that they can support all Socs' Pinctrl and how do you feel about using them. http://patchwork.ozlabs.org/patch/868849/ Which reminds

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-28 Thread David Wu
Hi Christoph, This patch seems is less of code about drive strength, for some modules, like LCD, Ethernet is still needed. 在 2018/12/27 下午9:13, Christoph Müllner 写道: Hi David, On 12/27/18 1:49 PM, David Wu wrote: Hi Christoph, I once submitted a series of patches that they can support all

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-27 Thread Philipp Tomsich
David, > On 27.12.2018, at 13:49, David Wu wrote: > > Hi Christoph, > > I once submitted a series of patches that they can support all Socs' Pinctrl > and how do you feel about using them. > > http://patchwork.ozlabs.org/patch/868849/ Which reminds me that I am still waiting for a newer revi

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-27 Thread Christoph Müllner
Hi David, On 12/27/18 1:49 PM, David Wu wrote: > Hi Christoph, > > I once submitted a series of patches that they can support all Socs' > Pinctrl and how do you feel about using them. Thank's for pointing to that. Your driver looks good, but I don't like the huge amount of duplication in it (yo

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-27 Thread David Wu
Hi Christoph, I once submitted a series of patches that they can support all Socs' Pinctrl and how do you feel about using them. http://patchwork.ozlabs.org/patch/868849/ 在 2018/12/27 上午9:11, Kever Yang 写道: Add David to review the pinctrl driver. Thanks, - Kever On 12/17/2018 09:30 PM, Chr

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-26 Thread Kever Yang
Add David to review the pinctrl driver. Thanks, - Kever On 12/17/2018 09:30 PM, Christoph Muellner wrote: > The current pinctrl driver for the RK3399 has a range of qulity issues. > E.g. it only implements the .set_state_simple() callback, it > does not parse the available pinctrl information fro

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-25 Thread Christoph Müllner
Hi Simon, On 12/20/18 10:17 PM, Simon Glass wrote: > On Mon, 17 Dec 2018 at 06:30, Christoph Muellner > wrote: >> >> The current pinctrl driver for the RK3399 has a range of qulity issues. >> E.g. it only implements the .set_state_simple() callback, it >> does not parse the available pinctrl info

Re: [U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-20 Thread Simon Glass
On Mon, 17 Dec 2018 at 06:30, Christoph Muellner wrote: > > The current pinctrl driver for the RK3399 has a range of qulity issues. > E.g. it only implements the .set_state_simple() callback, it > does not parse the available pinctrl information from the DTS > (instead uses hardcoded values), is n

[U-Boot] [PATCH v3 5/8] rockchip: rk3399: Add improved pinctrl driver.

2018-12-17 Thread Christoph Muellner
The current pinctrl driver for the RK3399 has a range of qulity issues. E.g. it only implements the .set_state_simple() callback, it does not parse the available pinctrl information from the DTS (instead uses hardcoded values), is not flexible enough to cover devices without 'interrupt' field in th