Re: [U-Boot] [PATCH v3 6/8] net/bootp: add VCI support for BOOTP also

2012-07-25 Thread Ilya Yanok
Hi Joe, On Wed, Jul 25, 2012 at 3:29 AM, Joe Hershberger wrote: > > > +#define put_vci(e, str)\ > > + do {\ > > + *e++ = 60; \ > > > Please keep the comment on the magic number. > Sure.

Re: [U-Boot] [PATCH v3 6/8] net/bootp: add VCI support for BOOTP also

2012-07-24 Thread Joe Hershberger
Hi Ilya, On Tue, Jul 24, 2012 at 5:22 PM, Ilya Yanok wrote: > Vendor Class Identifier option is common to BOOTP and DHCP and > can be useful without PXE. So send VCI in both BOOTP and DHCP > requests if CONFIG_BOOTP_VCI_STRING is defined. > > Signed-off-by: Ilya Yanok > --- > > net/bootp.c |

[U-Boot] [PATCH v3 6/8] net/bootp: add VCI support for BOOTP also

2012-07-24 Thread Ilya Yanok
Vendor Class Identifier option is common to BOOTP and DHCP and can be useful without PXE. So send VCI in both BOOTP and DHCP requests if CONFIG_BOOTP_VCI_STRING is defined. Signed-off-by: Ilya Yanok --- net/bootp.c | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) d