Re: [U-Boot] [PATCH v3 7/8] add support for palm treo 680 board

2013-04-15 Thread Mike Dunn
On 04/15/2013 11:33 AM, Marek Vasut wrote: > Dear Mike Dunn, > > [...] > +#ifdef CONFIG_SPL_BUILD +void *memcpy(void *dest, const void *src, size_t count) +{ >>> >>> CONFIG_SPL_LIBCOMMON_SUPPORT shall give you memcpy. >> >> This does not appear to be the case. Unless I'm mistaken,

Re: [U-Boot] [PATCH v3 7/8] add support for palm treo 680 board

2013-04-15 Thread Marek Vasut
Dear Mike Dunn, [...] > >> +#ifdef CONFIG_SPL_BUILD > >> +void *memcpy(void *dest, const void *src, size_t count) > >> +{ > > > > CONFIG_SPL_LIBCOMMON_SUPPORT shall give you memcpy. > > This does not appear to be the case. Unless I'm mistaken, memcpy() will be > in either lib/libgeneric.o (lib

Re: [U-Boot] [PATCH v3 7/8] add support for palm treo 680 board

2013-04-15 Thread Mike Dunn
On 04/14/2013 10:34 AM, Marek Vasut wrote: > Dear Mike Dunn, > > [...] > >> +int board_init(void) >> +{ >> +/* We have RAM, disable cache */ >> +dcache_disable(); >> +icache_disable(); >> + >> +gd->bd->bi_arch_number = MACH_TYPE_TREO680; > > This is not needed, just define CONFIG

Re: [U-Boot] [PATCH v3 7/8] add support for palm treo 680 board

2013-04-14 Thread Marek Vasut
Dear Mike Dunn, [...] > +int board_init(void) > +{ > + /* We have RAM, disable cache */ > + dcache_disable(); > + icache_disable(); > + > + gd->bd->bi_arch_number = MACH_TYPE_TREO680; This is not needed, just define CONFIG_MACH_TYPE in treo680.h > + gd->bd->bi_boot_params =

[U-Boot] [PATCH v3 7/8] add support for palm treo 680 board

2013-04-12 Thread Mike Dunn
A quick overview of u-boot implementation on the treo 680... The treo 680 has a Diskonchip G4 nand flash chip. This device has a 2k region that maps to the system bus at the reset vector in a NOR-like fashion so that it can be used as the boot device. The phone is shipped with this 2k region con