Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-20 Thread Stefano Babic
On 14/03/2013 03:32, Fabio Estevam wrote: > From: Fabio Estevam > > Add initial support for Wandboard. > > Wandboard is a development board that has two variants: one version based > on mx6 dual lite and another one based on mx6 solo. > > For details on the features of Wandboard, please refer t

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-15 Thread Wolfgang Denk
Dear Fabio Estevam, In message you wrote: > > >> +#define CONFIG_SYS_MEMTEST_START 0x1000 > >> +#define CONFIG_SYS_MEMTEST_END 0x1001 > > > > This makes no sense. Please see doc/README.memory-test > > This is something that always causes me confusion. > > doc/README

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-15 Thread Wolfgang Denk
Dear Stefano, In message <514367ed.6070...@denx.de> you wrote: > > It is ok to move the information to bdinfo, but then it should not break > the consistence: all i.MX should follow the same rule. This makes also > easier for board maintainers to switch from a SOC to the next one, > because they

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-15 Thread Fabio Estevam
On Fri, Mar 15, 2013 at 3:21 PM, Fabio Estevam wrote: > Hi Wolfgang, > > On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk wrote: > >>> +#define CONFIG_SYS_MEMTEST_START 0x1000 >>> +#define CONFIG_SYS_MEMTEST_END 0x1001 >> >> This makes no sense. Please see doc/README.memo

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-15 Thread Stefano Babic
On 15/03/2013 18:27, Wolfgang Denk wrote: > Dear Stefano Babic, > Hi Wolfgang, > I agree that it is important information, and there should be a way > that the user can get at this information. But I see no urgent need > to print this for everyboot, where it is just costing us precious boot > t

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-15 Thread Fabio Estevam
Hi Wolfgang, On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk wrote: >> +#define CONFIG_SYS_MEMTEST_START 0x1000 >> +#define CONFIG_SYS_MEMTEST_END 0x1001 > > This makes no sense. Please see doc/README.memory-test This is something that always causes me confusion. doc/

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-15 Thread Wolfgang Denk
Dear Stefano Babic, In message <5143365f.5000...@denx.de> you wrote: > > > Indeed this is common code, I see it now. So yes, if we change this, > > it should be done as separate patch. I think debug() makes a lot of > > sense here to reduce the output at boot time to a reasonable minimum, > > b

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-15 Thread Stefano Babic
On 14/03/2013 21:24, Wolfgang Denk wrote: > Dear Fabio, > Hi Wolfgang, hi Fabio, >>> Can we please remove the "Reset cause: WDOG" line in production mode? >> >> Do you mean the change below? >> >> --- a/arch/arm/imx-common/cpu.c >> +++ b/arch/arm/imx-common/cpu.c >> @@ -148,7 +148,7 @@ int print

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Scott Wood
On 03/14/2013 04:01:59 PM, Tom Rini wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/14/2013 04:36 PM, Wolfgang Denk wrote: > Dear Tom, > > In message <20130314173648.GX23324@bill-the-cat> you wrote: >> Is there any reason for not chosing the more standard 5 second delay? >>>

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Tom Rini
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 03/14/2013 04:36 PM, Wolfgang Denk wrote: > Dear Tom, > > In message <20130314173648.GX23324@bill-the-cat> you wrote: >> Is there any reason for not chosing the more standard 5 second delay? >>> >>> Ok, so let's go with 3 seconds then ;

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Wolfgang Denk
Dear Fabio Estevam, In message you wrote: > > >> +int checkboard(void) > >> +{ > >> + puts("Board: Wandboard\n"); > > > > Should we also add information about DL / Solo here? It would > > probably make sense... > > This is what we will get: > > CPU: Freescale i.MX6DL rev1.1 at 792 MHz

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Wolfgang Denk
Dear Tom, In message <20130314173648.GX23324@bill-the-cat> you wrote: > > > > Is there any reason for not chosing the more standard 5 second delay? > > > > Ok, so let's go with 3 seconds then ;-) > > There's a pretty even distribution of 1 3 and 5 second delays (with a > few 10s, 2s and 6s). I

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Wolfgang Denk
Dear Fabio, In message you wrote: > > > Is there any reason for not chosing the more standard 5 second delay? > > Ok, so let's go with 3 seconds then ;-) Why not 5? For development, 1 or 3 is often quite short. I've seen enough cases where connecting to a serial port (for example, through o

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Fabio Estevam
On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk wrote: >> +int checkboard(void) >> +{ >> + puts("Board: Wandboard\n"); > > Should we also add information about DL / Solo here? It would > probably make sense... This is what we will get: CPU: Freescale i.MX6DL rev1.1 at 792 MHz Board: Wandb

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Tom Rini
On Thu, Mar 14, 2013 at 02:01:20PM -0300, Fabio Estevam wrote: > Hi Wolfgang, > > On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk wrote: > > Dear Fabio Estevam, > > > > In message <1363228354-29534-1-git-send-email-feste...@gmail.com> you wrote: > >> From: Fabio Estevam > >> > >> Add initial supp

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Fabio Estevam
Hi Wolfgang, On Thu, Mar 14, 2013 at 9:31 AM, Wolfgang Denk wrote: > Dear Fabio Estevam, > > In message <1363228354-29534-1-git-send-email-feste...@gmail.com> you wrote: >> From: Fabio Estevam >> >> Add initial support for Wandboard. > > Subject and commit message are redundant, resulting in tex

Re: [U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-14 Thread Wolfgang Denk
Dear Fabio Estevam, In message <1363228354-29534-1-git-send-email-feste...@gmail.com> you wrote: > From: Fabio Estevam > > Add initial support for Wandboard. Subject and commit message are redundant, resulting in text like this: Add initial support for Wandboard dual lite and solo.

[U-Boot] [PATCH v4] Add initial support for Wandboard dual lite and solo.

2013-03-13 Thread Fabio Estevam
From: Fabio Estevam Add initial support for Wandboard. Wandboard is a development board that has two variants: one version based on mx6 dual lite and another one based on mx6 solo. For details on the features of Wandboard, please refer to: http://www.wandboard.org/ Signed-off-by: Fabio Estevam