Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-06 Thread Mike Frysinger
On Tuesday 06 March 2012 03:24:34 Marek Vasut wrote: > > On Friday 02 March 2012 11:45:15 Wolfgang Denk wrote: > > > > > That's what I did in original patch where I am aligning it by > > > > > adding the line > > > > > > > > > > +/* Device Descriptor */ > > > > > +#ifdef ARCH_DMA_MINALIGN

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-06 Thread Marek Vasut
Dear Mike Frysinger, > On Friday 02 March 2012 11:45:15 Wolfgang Denk wrote: > > > > That's what I did in original patch where I am aligning it by adding > > > > the line > > > > > > > > +/* Device Descriptor */ > > > > +#ifdef ARCH_DMA_MINALIGN > > > > + struct usb_device_descripto

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-05 Thread Mike Frysinger
On Friday 02 March 2012 11:45:15 Wolfgang Denk wrote: > > > That's what I did in original patch where I am aligning it by adding > > > the line > > > > > > +/* Device Descriptor */ > > > +#ifdef ARCH_DMA_MINALIGN > > > + struct usb_device_descriptor descriptor > > > + _

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread Wolfgang Denk
In message <201203021659.21568.ma...@denx.de> you wrote: > ... > > That's what I did in original patch where I am aligning it by adding the > > line > > > > +/* Device Descriptor */ > > +#ifdef ARCH_DMA_MINALIGN > > + struct usb_device_descriptor descriptor > > + __attr

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread Marek Vasut
> On Friday 02 March 2012 08:11 PM, Marek Vasut wrote: > >> On Friday 02 March 2012 07:16 PM, Marek Vasut wrote: > As DMA expects the buffers to be equal and larger then > cache lines, This aligns buffers at cacheline. > > Signed-off-by: Puneet Saxena > --- > >

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread puneets
On Friday 02 March 2012 08:11 PM, Marek Vasut wrote: On Friday 02 March 2012 07:16 PM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena --- Changes for V3: - Removed local descriptor elem

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread Marek Vasut
> On Friday 02 March 2012 07:16 PM, Marek Vasut wrote: > >> As DMA expects the buffers to be equal and larger then > >> cache lines, This aligns buffers at cacheline. > >> > >> Signed-off-by: Puneet Saxena > >> --- > >> > >> Changes for V3: > >> - Removed local descriptor elements copy to gl

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread puneets
On Friday 02 March 2012 07:16 PM, Marek Vasut wrote: As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena --- Changes for V3: - Removed local descriptor elements copy to global descriptor elements - Removed

Re: [U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread Marek Vasut
> As DMA expects the buffers to be equal and larger then > cache lines, This aligns buffers at cacheline. > > Signed-off-by: Puneet Saxena > --- > > Changes for V3: > - Removed local descriptor elements copy to global descriptor elements > - Removed "Signed-off-by: Jim Lin " from commit

[U-Boot] [PATCH v4] usb: align buffers at cacheline

2012-03-02 Thread Puneet Saxena
As DMA expects the buffers to be equal and larger then cache lines, This aligns buffers at cacheline. Signed-off-by: Puneet Saxena --- Changes for V3: - Removed local descriptor elements copy to global descriptor elements - Removed "Signed-off-by: Jim Lin " from commit message Changes f