Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2014-01-26 Thread Simon Glass
Hi Detlev, On 17 January 2014 08:13, Detlev Zundel d...@denx.de wrote: Hi Simon, [...] I think the Linux code has two big advantages - for one, we increase the overlap with Linux kernel proper and secondly we keep the 'grep'ability of the names which I really missed in your proposal.

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2014-01-17 Thread Detlev Zundel
Hi Simon, [...] I think the Linux code has two big advantages - for one, we increase the overlap with Linux kernel proper and secondly we keep the 'grep'ability of the names which I really missed in your proposal. Yes that seems reasonable. Ok, I'm glad we are in agreement. Many of

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2014-01-15 Thread Simon Glass
Hi Detlev, On 14 January 2014 03:11, Detlev Zundel d...@denx.de wrote: Hi Simon, as I don't see any follow-up, allow me to jump in here even that late :) Hi Wolfgang, On Wed, Nov 6, 2013 at 1:24 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2014-01-14 Thread Detlev Zundel
Hi Simon, as I don't see any follow-up, allow me to jump in here even that late :) Hi Wolfgang, On Wed, Nov 6, 2013 at 1:24 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-11-10 Thread Wolfgang Denk
Dear Simon, In message capnjgz3b4szi_2h2sw7oop932ccgou8ho5e_fkmjcyv4ws+...@mail.gmail.com you wrote: ... By chance I ran about include/linux/kconfig.h in the Linux kernel tree, which provides (among other things) the IS_ENABLED() macro that implements essentially the very same feature.

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-11-09 Thread Simon Glass
Hi Wolfgang, On Wed, Nov 6, 2013 at 1:24 AM, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-11-07 Thread Albert ARIBAUD
Hi Wolfgang, On Wed, 06 Nov 2013 08:24:44 +0100, Wolfgang Denk w...@denx.de wrote: Dear Simon Glass, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-11-06 Thread Stefan Roese
Hi Wolfgang, On 06.11.2013 08:24, Wolfgang Denk wrote: snip if (autoconf_version_variable()) setenv(ver, version_string); /* set version variable */ By chance I ran about include/linux/kconfig.h in the Linux kernel tree, which provides (among other things) the

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-11-05 Thread Wolfgang Denk
Dear Simon Glass, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-10-28 Thread Wolfgang Denk
Dear Simon, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It is easy

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-10-28 Thread Tom Rini
On Mon, Oct 28, 2013 at 03:44:01PM +0100, Wolfgang Denk wrote: Dear Simon, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code,

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-10-28 Thread Simon Glass
Hi Tom, On Mon, Oct 28, 2013 at 9:32 AM, Tom Rini tr...@ti.com wrote: On Mon, Oct 28, 2013 at 03:44:01PM +0100, Wolfgang Denk wrote: Dear Simon, In message 1382800457-26608-1-git-send-email-...@chromium.org you wrote: Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes

[U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-10-26 Thread Simon Glass
Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It is easy to misspell an #ifdef and there is not as much checking of this by the compiler.

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-06-27 Thread Albert ARIBAUD
Hi Simon, On Mon, 24 Jun 2013 17:52:03 -0700, Simon Glass s...@chromium.org wrote: Hi Albert, On Sun, Jun 23, 2013 at 12:29 AM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Simon, On Mon, 17 Jun 2013 07:44:52 -0700, Simon Glass s...@chromium.org wrote: Note that a

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-06-27 Thread Simon Glass
Hi Albert, On Thu, Jun 27, 2013 at 12:04 AM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Simon, On Mon, 24 Jun 2013 17:52:03 -0700, Simon Glass s...@chromium.org wrote: Hi Albert, On Sun, Jun 23, 2013 at 12:29 AM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Simon,

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-06-24 Thread Simon Glass
Hi Albert, On Sun, Jun 23, 2013 at 12:29 AM, Albert ARIBAUD albert.u.b...@aribaud.netwrote: Hi Simon, On Mon, 17 Jun 2013 07:44:52 -0700, Simon Glass s...@chromium.org wrote: Note that a config_drop.h file is added - this defines all the CONFIGs which are not used in any board config

Re: [U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-06-23 Thread Albert ARIBAUD
Hi Simon, On Mon, 17 Jun 2013 07:44:52 -0700, Simon Glass s...@chromium.org wrote: Note that a config_drop.h file is added - this defines all the CONFIGs which are not used in any board config file. Without this, autoconf cannot define the macros for this CONFIGs. Compile time for main.c

[U-Boot] [PATCH v4 0/8] Provide a mechanism to avoid using #ifdef everywhere

2013-06-17 Thread Simon Glass
Many parts of the U-Boot code base are sprinkled with #ifdefs. This makes different boards compile different versions of the source code, meaning that we must build all boards to check for failures. It is easy to misspell an #ifdef and there is not as much checking of this by the compiler.