Re: [U-Boot] [PATCH v4 2/6] lib: uuid: code refactor for proper maintain between uuid bin and string

2014-03-26 Thread Stephen Warren
On 03/26/2014 06:00 AM, Przemyslaw Marczak wrote: > Hello Stephen, > Thanks for review again:) > > On 03/25/2014 08:12 PM, Stephen Warren wrote: >> On 03/19/2014 11:58 AM, Przemyslaw Marczak wrote: >>> Changes in lib/uuid.c to: >>> - uuid_str_to_bin() >>> - uuid_bin_to_str() >>> >>> New parameter

Re: [U-Boot] [PATCH v4 2/6] lib: uuid: code refactor for proper maintain between uuid bin and string

2014-03-26 Thread Przemyslaw Marczak
Hello Stephen, Thanks for review again:) On 03/25/2014 08:12 PM, Stephen Warren wrote: On 03/19/2014 11:58 AM, Przemyslaw Marczak wrote: Changes in lib/uuid.c to: - uuid_str_to_bin() - uuid_bin_to_str() New parameter is added to specify input/output string format in listed functions This chang

Re: [U-Boot] [PATCH v4 2/6] lib: uuid: code refactor for proper maintain between uuid bin and string

2014-03-25 Thread Stephen Warren
On 03/19/2014 11:58 AM, Przemyslaw Marczak wrote: > Changes in lib/uuid.c to: > - uuid_str_to_bin() > - uuid_bin_to_str() > > New parameter is added to specify input/output string format in listed > functions > This change allows easy recognize which UUID type is or should be stored in > given >

Re: [U-Boot] [PATCH v4 2/6] lib: uuid: code refactor for proper maintain between uuid bin and string

2014-03-19 Thread Wolfgang Denk
Dear Przemyslaw Marczak, In message <1395251911-26540-2-git-send-email-p.marc...@samsung.com> you wrote: > Changes in lib/uuid.c to: > - uuid_str_to_bin() > - uuid_bin_to_str() Checkpatch says: WARNING: do not add new typedefs #199: FILE: include/uuid.h:10: +typedef enum { WARNING: line over 80

[U-Boot] [PATCH v4 2/6] lib: uuid: code refactor for proper maintain between uuid bin and string

2014-03-19 Thread Przemyslaw Marczak
Changes in lib/uuid.c to: - uuid_str_to_bin() - uuid_bin_to_str() New parameter is added to specify input/output string format in listed functions This change allows easy recognize which UUID type is or should be stored in given string array. Binary data of UUID and GUID is always stored in big e