[U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-09-23 Thread Vikas Manocha
No need to configure indirect trigger address for every read/write. Signed-off-by: Vikas Manocha --- Changes in v7: None Changes in v6: None Changes in v5: fixed type cast compilation warnings. Changes in v4: removed extra type casts. Changes in v3: added commit message & removed extra bracket.

Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-09-24 Thread Wolfgang Denk
Dear Vikas, In message <1443053976-9112-2-git-send-email-vikas.mano...@st.com> you wrote: > No need to configure indirect trigger address for every read/write. ... > /* Indirect mode configurations */ > writel((plat->sram_size/2), plat->regbase + CQSPI_REG_SRAMPARTITION); > + write

Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-09-24 Thread Vikas MANOCHA
: Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base > configuration in init > > Dear Vikas, > > In message <1443053976-9112-2-git-send-email-vikas.mano...@st.com> > you wrote: > > No need to configure indirect trigger address for every read/w

Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-09-24 Thread Wolfgang Denk
Dear Vikas, In message <9026814fbf99304f9fa3ac3fb72f3e2f04bff85...@safex1mail4.st.com> you wrote: > > > CQSPI_INDIRECTTRIGGER_ADDR_MASK, > > > +plat->regbase + CQSPI_REG_INDIRECTTRIGGER); > > > > I did not mention this explicitly, so I do it here: > > > > Please fix this type cast issue

Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-09-24 Thread Jagan Teki
Hi Wolfgang, On 25 September 2015 at 00:26, Wolfgang Denk wrote: > Dear Vikas, > > In message <9026814fbf99304f9fa3ac3fb72f3e2f04bff85...@safex1mail4.st.com> > you wrote: >> >> > CQSPI_INDIRECTTRIGGER_ADDR_MASK, >> > > +plat->regbase + CQSPI_REG_INDIRECTTRIGGER); >> > >> > I did not ment

Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-09-24 Thread Wolfgang Denk
Dear Jagan, In message you wrote: > > What if we move Vikas changes now for this release as he stated in > previous mail "about sending patches later". Well, we've been there too many times before. In to many cases, the "later" just did not happen. > My idea is someone is trying to clean it

Re: [U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base configuration in init

2015-09-25 Thread Vikas MANOCHA
U-Boot] [PATCH v7 1/6] spi: cadence_qspi: move trigger base > configuration in init > > Dear Jagan, > > In message gv4...@mail.gmail.com> you wrote: > > > > What if we move Vikas changes now for this release as he stated in > > previous mail "about sending pat