Re: [U-Boot] [PATCHv2] pca953x: support 16-pin devices

2010-12-08 Thread Peter Tyser
The patch looks good. I had a few minor nitpicky style comments below: As suggested by Peter I've implemented the 16-pin support in the existing pca953x driver. So this is pretty much a re-write of the v1 patch. Is the commit message sufficient to document CONFIG_SYS_I2C_PCA953X_WIDTH or is

Re: [U-Boot] [PATCHv2] pca953x: support 16-pin devices

2010-12-08 Thread Chris Packham
On Thu, Dec 9, 2010 at 1:08 PM, Peter Tyser pty...@xes-inc.com wrote: The patch looks good.  I had a few minor nitpicky style comments below: As suggested by Peter I've implemented the 16-pin support in the existing pca953x driver. So this is pretty much a re-write of the v1 patch. Is the

[U-Boot] [PATCHv2] pca953x: support 16-pin devices

2010-12-07 Thread Chris Packham
This adds support for for the PCA9535/PCA9539 family of gpio devices which have 16 output pins. To let the driver know which devices are 16-pin it is necessary to define CONFIG_SYS_I2C_PCA953X_WIDTH in your board config file. This is used to create an array of {chip, ngpio} tuples that are used