After discussing it with Maxime in IRC I decided to wait till pinctrl
driver for sunxi is ready.
Please kindly disregard this series.
Regards,
Vasily
On Fri, Sep 22, 2017 at 7:44 AM, Maxime Ripard
wrote:
> On Fri, Sep 22, 2017 at 04:42:24AM +, Vasily Khoruzhick wrote:
>> >> >>> + lcdc_i
On Fri, Sep 22, 2017 at 04:42:24AM +, Vasily Khoruzhick wrote:
> >> >>> + lcdc_init(lcdc);
> >> >>> + sunxi_lcdc_config_pinmux();
> >> >>
> >> >> This is already handled in sunxi_lcdc_tcon0_mode_set, why duplicate
> >> >> it?
> >> >
> >> > Because the one that sunxi_lcdc_tcon0_mode_set(
Hi Maxime,
On Wed, Sep 20, 2017 at 11:51 PM, Maxime Ripard
wrote:
> On Thu, Sep 21, 2017 at 05:33:36AM +, Vasily Khoruzhick wrote:
>> >>> + ret = uclass_find_device_by_name(UCLASS_DISPLAY,
>> >>> + "sunxi_lcd", &disp);
>> >>> + if (!ret) {
>> >>> +
在 2017-09-21 14:51，Maxime Ripard 写道：
On Thu, Sep 21, 2017 at 05:33:36AM +, Vasily Khoruzhick wrote:
>>> + ret = uclass_find_device_by_name(UCLASS_DISPLAY,
>>> + "sunxi_lcd", &disp);
>>> + if (!ret) {
>>> + int mux;
>>> +
>>> +
On Thu, Sep 21, 2017 at 05:33:36AM +, Vasily Khoruzhick wrote:
> >>> + ret = uclass_find_device_by_name(UCLASS_DISPLAY,
> >>> + "sunxi_lcd", &disp);
> >>> + if (!ret) {
> >>> + int mux;
> >>> +
> >>> + mux = 0;
> >>> +
> >>> +
Hi,
I did few tests, see results inline.
On Tue, Sep 19, 2017 at 12:00 PM, Vasily Khoruzhick wrote:
> On Tue, Sep 19, 2017 at 1:33 AM, Maxime Ripard
> wrote:
>> On Mon, Sep 18, 2017 at 10:04:21PM -0700, Vasily Khoruzhick wrote:
>>> Extend DE2 driver with LCD support
>>
>> (All) your commit mess
于 2017年9月20日 GMT+08:00 上午3:00:30, Vasily Khoruzhick 写到:
>On Tue, Sep 19, 2017 at 1:33 AM, Maxime Ripard
> wrote:
>> On Mon, Sep 18, 2017 at 10:04:21PM -0700, Vasily Khoruzhick wrote:
>>> Extend DE2 driver with LCD support
>>
>> (All) your commit messages could use a bit more details.
>
>OK, will
Hi,
Dne torek, 19. september 2017 ob 21:00:30 CEST je Vasily Khoruzhick
napisal(a):
> On Tue, Sep 19, 2017 at 1:33 AM, Maxime Ripard
>
> wrote:
> > On Mon, Sep 18, 2017 at 10:04:21PM -0700, Vasily Khoruzhick wrote:
> >> Extend DE2 driver with LCD support
> >
> > (All) your commit messages coul
On Tue, Sep 19, 2017 at 1:33 AM, Maxime Ripard
wrote:
> On Mon, Sep 18, 2017 at 10:04:21PM -0700, Vasily Khoruzhick wrote:
>> Extend DE2 driver with LCD support
>
> (All) your commit messages could use a bit more details.
OK, will add in v2.
> Here, for example, explaining the following things w
On Mon, Sep 18, 2017 at 10:04:21PM -0700, Vasily Khoruzhick wrote:
> Extend DE2 driver with LCD support
(All) your commit messages could use a bit more details.
Here, for example, explaining the following things would help:
- Why are you creating yet another file
- What is the situation with
Extend DE2 driver with LCD support
Signed-off-by: Vasily Khoruzhick
---
arch/arm/mach-sunxi/Kconfig | 2 +-
drivers/video/sunxi/Makefile| 2 +-
drivers/video/sunxi/sunxi_de2.c | 17 +
drivers/video/sunxi/sunxi_lcd.c | 142
4 files changed
11 matches
Mail list logo
