Re: [U-Boot] [RESEND PATCH v2 2/4] clk: clk_fixed_rate: Fix style violation

2018-01-21 Thread Simon Glass
On 15 January 2018 at 06:05, Tom Rini wrote: > On Mon, Jan 15, 2018 at 11:44:46AM +0100, Mario Six wrote: >> On Mon, Jan 15, 2018 at 11:19 AM, Dr. Philipp Tomsich >> wrote: >> > Tom, >> > >> >> On 15 Jan 2018, at 11:06, Mario Six wrote: >> >> >> >> Fix a mis-indented function call in clk_fixed_r

Re: [U-Boot] [RESEND PATCH v2 2/4] clk: clk_fixed_rate: Fix style violation

2018-01-15 Thread Tom Rini
On Mon, Jan 15, 2018 at 11:44:46AM +0100, Mario Six wrote: > On Mon, Jan 15, 2018 at 11:19 AM, Dr. Philipp Tomsich > wrote: > > Tom, > > > >> On 15 Jan 2018, at 11:06, Mario Six wrote: > >> > >> Fix a mis-indented function call in clk_fixed_rate.c > > > > A general question: do we want to have su

Re: [U-Boot] [RESEND PATCH v2 2/4] clk: clk_fixed_rate: Fix style violation

2018-01-15 Thread Mario Six
On Mon, Jan 15, 2018 at 11:19 AM, Dr. Philipp Tomsich wrote: > Tom, > >> On 15 Jan 2018, at 11:06, Mario Six wrote: >> >> Fix a mis-indented function call in clk_fixed_rate.c > > A general question: do we want to have such gardening commits > create an additional indirection in our history for pe

Re: [U-Boot] [RESEND PATCH v2 2/4] clk: clk_fixed_rate: Fix style violation

2018-01-15 Thread Dr. Philipp Tomsich
Tom, > On 15 Jan 2018, at 11:06, Mario Six wrote: > > Fix a mis-indented function call in clk_fixed_rate.c A general question: do we want to have such gardening commits create an additional indirection in our history for people using git-blame frequently (e.g. I usually use git-blame to find th

[U-Boot] [RESEND PATCH v2 2/4] clk: clk_fixed_rate: Fix style violation

2018-01-15 Thread Mario Six
Fix a mis-indented function call in clk_fixed_rate.c Reviewed-by: Simon Glass Signed-off-by: Mario Six --- v1 -> v2: None --- drivers/clk/clk_fixed_rate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clk/clk_fixed_rate.c b/drivers/clk/clk_fixed_rate.c index