Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi, On 27 December 2016 at 20:32, Kever Yang wrote: > Init the clock rate to max-frequency from dts with clock driver api. > > Signed-off-by: Kever Yang > --- > > Changes in v3: > - using dt for max-frequency > Series-changes: 2 > - using the return value > > drivers/mmc/rockchip_sdhci.c | 19 +

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi, Am 02.01.2017 um 02:29 schrieb Jaehoon Chung: Hi Stefan, [snip] Of_course, it needs to consider the base clock broken case. The whole discussion is about the base clock broken case. Otherwise the host->max_clk is extracted from the SDHCI_CAPABILITIES. The linux kernel use a callback to

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi Stefan, On 12/31/2016 12:07 AM, Stefan Herbrechtsmeier wrote: > Hi, [snip] In Conclusion, host's maximum value is used. ("max_frequency" property is used to QUIRK_BROKEN_CAP_CLOCK_BASE in Linux kernel.) >>> The conclusion is wrong. The host->max_clk isn't influenced by th

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi, Am 30.12.2016 um 01:13 schrieb Jaehoon Chung: Hi Stefan, On 12/30/2016 12:41 AM, Stefan Herbrechtsmeier wrote: Hi, Am 29.12.2016 um 08:44 schrieb Jaehoon Chung: Hi On 12/29/2016 09:53 AM, Kever Yang wrote: Hi Stefan, Thanks for your review comment. On 12/29/2016 02:35 AM, Stefan

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi Stefan, On 12/30/2016 12:41 AM, Stefan Herbrechtsmeier wrote: > Hi, > > Am 29.12.2016 um 08:44 schrieb Jaehoon Chung: >> Hi >> >> On 12/29/2016 09:53 AM, Kever Yang wrote: >>> Hi Stefan, >>> >>> Thanks for your review comment. >>> On 12/29/2016 02:35 AM, Stefan Herbrechtsmeier wrote:

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi, Am 29.12.2016 um 08:44 schrieb Jaehoon Chung: Hi On 12/29/2016 09:53 AM, Kever Yang wrote: Hi Stefan, Thanks for your review comment. On 12/29/2016 02:35 AM, Stefan Herbrechtsmeier wrote: Hi, Am 28.12.2016 um 12:01 schrieb Jaehoon Chung: On 12/28/2016 12:32 PM, Kever Yang wrote:

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi On 12/29/2016 09:53 AM, Kever Yang wrote: > Hi Stefan, > > Thanks for your review comment. > On 12/29/2016 02:35 AM, Stefan Herbrechtsmeier wrote: >> Hi, >> >> Am 28.12.2016 um 12:01 schrieb Jaehoon Chung: >>> On 12/28/2016 12:32 PM, Kever Yang wrote: Init the clock rate to max-freque

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi Stefan, Thanks for your review comment. On 12/29/2016 02:35 AM, Stefan Herbrechtsmeier wrote: Hi, Am 28.12.2016 um 12:01 schrieb Jaehoon Chung: On 12/28/2016 12:32 PM, Kever Yang wrote: Init the clock rate to max-frequency from dts with clock driver api. Signed-off-by: Kever Yang Re

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Hi, Am 28.12.2016 um 12:01 schrieb Jaehoon Chung: On 12/28/2016 12:32 PM, Kever Yang wrote: Init the clock rate to max-frequency from dts with clock driver api. Signed-off-by: Kever Yang Reviewed-by: Jaehoon Chung This is an incorrect use of the max-frequency property. The max-frequency v

Re: [U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

On 12/28/2016 12:32 PM, Kever Yang wrote: > Init the clock rate to max-frequency from dts with clock driver api. > > Signed-off-by: Kever Yang Reviewed-by: Jaehoon Chung Best Regards, Jaehoon Chung > --- > > Changes in v3: > - using dt for max-frequency > Series-changes: 2 > - using the retu

[U-Boot] [RESEND PATCH v3 1/2] mmc: rockchip_sdhci: add clock init for mmc

Init the clock rate to max-frequency from dts with clock driver api. Signed-off-by: Kever Yang --- Changes in v3: - using dt for max-frequency Series-changes: 2 - using the return value drivers/mmc/rockchip_sdhci.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) dif