Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-05 Thread Wolfgang Denk
Dear Jeroen, In message <50e7fb65.9000...@myspectrum.nl> you wrote: > > > Hm... I'm not sure if this is the right approach, then. If mainline > > Linux insists on such a 2 MB alignment, we shoud rather teach > > lcd_setmem() to follow tha rule, too. That should solve the problem > > as well (a

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-05 Thread Jeroen Hofstee
Hi, On 01/03/2013 09:28 PM, Wolfgang Denk wrote: Hm... I'm not sure if this is the right approach, then. If mainline Linux insists on such a 2 MB alignment, we shoud rather teach lcd_setmem() to follow tha rule, too. That should solve the problem as well (and probably more efficiently, especi

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-04 Thread Jeroen Hofstee
Hi Wolfgang, On 01/03/2013 09:28 PM, Wolfgang Denk wrote: The frame buffer is then at the same physical address and I regain 15MB of memory. So solved as far as I am concerned till proven that it really hurts performance. I can't grok this, though. I could understand if you say you saved up to

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-03 Thread Wolfgang Denk
Dear Jeroen Hofstee, In message <50e5c9a2.7090...@myspectrum.nl> you wrote: > > > In any case the code should behave the same in U-Boot and Linux. If > > we can lift this restriction in Linux, then OK. If not, then the FB > > allocation in U-Boot (by lcd_setmem()) should result in the same size

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-03 Thread Jeroen Hofstee
Hi, On 01/03/2013 11:41 AM, Wolfgang Denk wrote: In message <50e55d24.8000...@myspectrum.nl> you wrote: As Wolfgang suggested, maybe I shouldn't point at U-boot but blame linux and get rid of the 2MB alignment. I haven't checked yet, but I don't see why that should not work. So this is resolved

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-03 Thread Wolfgang Denk
Dear Jeroen, In message <50e55d24.8000...@myspectrum.nl> you wrote: > > So the intention was to fix that while preserving the frame buffer and I > don't want linux to steal so much memory. The minimum amount of > memory the dss accepts is 2MB though (for reason unknown to me). > Without the fb ad

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-03 Thread Jeroen Hofstee
Hello Tom, Wolfgang, On 01/02/2013 09:17 PM, Wolfgang Denk wrote: Dear Tom, In message <20130102154854.GC14738@bill-the-cat> you wrote: I think this means we've got people not understanding what the variable IS for. And at the high level, the idea of "lets transition from U-Boot to Linux with

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-02 Thread Wolfgang Denk
Dear Tom, In message <20130102154854.GC14738@bill-the-cat> you wrote: > > > Please see my responses. This is definitely NOT a good idea, it will > > break most (all?) boards that use CONFIG_FB_ADDR in the way it was > > intended for. > > I think this means we've got people not understanding wha

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2013-01-02 Thread Tom Rini
On Mon, Dec 31, 2012 at 03:54:25PM +0100, Wolfgang Denk wrote: > Dear Lukasz Majewski, > > In message <20121231153353.2d9a5dda@amdc308.digital.local> you wrote: > > > > > - addr = lcd_setmem(addr); > > > - gd->fb_base = addr; > > > + gd->fb_base = lcd_setmem(addr); > > > #endif

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2012-12-31 Thread Wolfgang Denk
Dear Lukasz Majewski, In message <20121231153353.2d9a5dda@amdc308.digital.local> you wrote: > > > - addr = lcd_setmem(addr); > > - gd->fb_base = addr; > > + gd->fb_base = lcd_setmem(addr); > > #endif /* CONFIG_FB_ADDR */ > > + /* always continue placement below the frame

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2012-12-31 Thread Lukasz Majewski
Hi Jeroen, > Hi All, > > Currently CONFIG_FB_ADDR can be set to specify the location of the > frame buffer. Since Linux places the frame buffer at the end of the > RAM, it is nice to place it at the same position so the u-boot to > linux transition can be made flicker free, by preserving the > fr

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2012-12-29 Thread Wolfgang Denk
Dear Jeroen Hofstee, In message <20121229211050.3249f8b7@black> you wrote: > > My apologies, I pasted half the patch, the intention is to always > set addr = gd->fb_base. No, this is not correct. If CONFIG_FB_ADDR is set, then it will usually points to the start address of an on on-chip video

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2012-12-29 Thread Wolfgang Denk
Dear Jeroen Hofstee, please be more careful with the mail addresses in your postings: repl: bad addresses: m...@mimc.co.uk; -- extraneous semi-colon l.majew...@samsung.com; -- extraneous semi-colon u-b...@denx.de -- no such address In message <20121229203157.0f50ba5e@bla

Re: [U-Boot] [RFC]: always relocate u-boot before the framebuffer

2012-12-29 Thread Jeroen Hofstee
> Currently CONFIG_FB_ADDR can be set to specify the location of the > frame buffer. Since Linux places the frame buffer at the end of the > RAM, it is nice to place it at the same position so the u-boot to > linux transition can be made flicker free, by preserving the > frame buffer. However u-bo

[U-Boot] [RFC]: always relocate u-boot before the framebuffer

2012-12-29 Thread Jeroen Hofstee
Hi All, Currently CONFIG_FB_ADDR can be set to specify the location of the frame buffer. Since Linux places the frame buffer at the end of the RAM, it is nice to place it at the same position so the u-boot to linux transition can be made flicker free, by preserving the frame buffer. However u-boot