Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-04 Thread Thierry Reding
On Tue, Oct 02, 2012 at 08:46:04PM +0200, Albert ARIBAUD wrote: Under option -munaligned-access, gcc can perform local char or 16-bit array initializations using misaligned native accesses which will throw a data abort exception. Fix files where these array initializations were unneeded, and

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-04 Thread Lucas Stach
Hi Albert, Am Dienstag, den 02.10.2012, 20:46 +0200 schrieb Albert ARIBAUD: Under option -munaligned-access, gcc can perform local char or 16-bit array initializations using misaligned native accesses which will throw a data abort exception. Fix files where these array initializations were

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-04 Thread Albert ARIBAUD
Hi Mark, On Wed, 3 Oct 2012 09:29:09 +0200, Mark Marshall mark.marsh...@omicron.at wrote: I've just had a quick look at this in passing, but at least some of these changes seem wrong to me. For example, the code in board/ti/omap2420h4/sys_info.c :: display_board_info should be: void

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-03 Thread Mark Marshall
I've just had a quick look at this in passing, but at least some of these changes seem wrong to me. For example, the code in board/ti/omap2420h4/sys_info.c :: display_board_info should be: void display_board_info(u32 btype) { static const char cpu_2420[] = 2420; /* cpu type */

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-03 Thread Joakim Tjernlund
Albert ARIBAUD albert.u.b...@aribaud.net wrote on 2012/10/02 22:05:40: Hi Joakim, On Tue, 2 Oct 2012 21:13:39 +0200, Joakim Tjernlund joakim.tjernl...@transmode.se wrote: */ void display_board_info(u32 btype)

[U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-02 Thread Albert ARIBAUD
Under option -munaligned-access, gcc can perform local char or 16-bit array initializations using misaligned native accesses which will throw a data abort exception. Fix files where these array initializations were unneeded, and for files known to contain such initializations, enforce gcc option

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-02 Thread Joakim Tjernlund
*/ void display_board_info(u32 btype) { - char cpu_2420[] = 2420; /* cpu type */ - char cpu_2422[] = 2422; - char cpu_2423[] = 2423; - char db_men[] = Menelaus; /* board type */ - char db_ip[] = IP; -

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-02 Thread Albert ARIBAUD
Hi Joakim, On Tue, 2 Oct 2012 21:13:39 +0200, Joakim Tjernlund joakim.tjernl...@transmode.se wrote: */ void display_board_info(u32 btype) { - char cpu_2420[] = 2420; /* cpu type */ - char cpu_2422[] =

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-02 Thread Stephen Warren
On 10/02/2012 12:46 PM, Albert ARIBAUD wrote: Under option -munaligned-access, gcc can perform local char or 16-bit array initializations using misaligned native accesses which will throw a data abort exception. Fix files where these array initializations were unneeded, and for files known to

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-02 Thread Albert ARIBAUD
Hi Stephen, On Tue, 02 Oct 2012 14:06:53 -0600, Stephen Warren swar...@wwwdotorg.org wrote: +c) Relax the -munified-access rule globally. This will prevent native I assume that's meant to say -munaligned-access? + until the target gets compiled with m-unaligned-access. s/m-/-m/

Re: [U-Boot] [RFC] ARM: prevent misaligned array inits

2012-10-02 Thread Måns Rullgård
Albert ARIBAUD albert.u.b...@aribaud.net writes: Under option -munaligned-access, gcc can perform local char or 16-bit array initializations using misaligned native accesses which will throw a data abort exception. Fix files where these array initializations were unneeded, and for files