Re: [U-Boot] [RFC] Add 'led' command

2011-12-16 Thread Ulf Samuelsson
I think that before we go ahead and do changes, we should ask ourselves: Why does a bootloader need LED support? Just because its on the board? Do we need to support all LEDs because they are there? i implemented the LED command because it seemed to have some application, even though I could not

Re: [U-Boot] [RFC] Add 'led' command

2011-12-15 Thread Jason Kridner
I hope I'm not too far off from understanding the comments made at the end of this thread... On Wed, Dec 14, 2011 at 4:31 PM, Simon Glass wrote: > Hi, > > On Wed, Dec 14, 2011 at 11:38 AM, Ulf Samuelsson > wrote: >> On 2011-12-14 20:11, Simon Glass wrote: >>> >>> Hi, >>> >>> On Tue, Dec 13, 2011

Re: [U-Boot] [RFC] Add 'led' command

2011-12-14 Thread Simon Glass
Hi, On Wed, Dec 14, 2011 at 11:38 AM, Ulf Samuelsson wrote: > On 2011-12-14 20:11, Simon Glass wrote: >> >> Hi, >> >> On Tue, Dec 13, 2011 at 3:55 PM, Ulf Samuelsson >>  wrote: >>> >>> On 2010-11-05 13:21, Wolfgang Denk wrote: Dear Jason Kridner, In message<1288936236-30603-1

Re: [U-Boot] [RFC] Add 'led' command

2011-12-14 Thread Simon Glass
Hi, On Tue, Dec 13, 2011 at 3:55 PM, Ulf Samuelsson wrote: > On 2010-11-05 13:21, Wolfgang Denk wrote: >> >> Dear Jason Kridner, >> >> In message<1288936236-30603-1-git-send-email-jkrid...@beagleboard.org> >>  you wrote: >>> >>> It is desired to have the led command on the BeagleBoard to allow fo

Re: [U-Boot] [RFC] Add 'led' command

2011-12-13 Thread Ulf Samuelsson
On 2010-11-05 13:21, Wolfgang Denk wrote: Dear Jason Kridner, In message<1288936236-30603-1-git-send-email-jkrid...@beagleboard.org> you wrote: It is desired to have the led command on the BeagleBoard to allow for some interaction in the scripts. This patch allows any board implementing the

Re: [U-Boot] [RFC] Add 'led' command

2010-11-18 Thread Mike Frysinger
On Saturday, November 13, 2010 18:31:39 Mike Frysinger wrote: > On Friday, November 12, 2010 09:42:52 Jason Kridner wrote: > > On Tue, Nov 9, 2010 at 8:52 AM, Mike Frysinger wrote: > > > On Friday, November 05, 2010 01:50:36 Jason Kridner wrote: > > >> + if (strcmp(argv[2], "off") == 0) { > > >

Re: [U-Boot] [RFC] Add 'led' command

2010-11-13 Thread Mike Frysinger
On Friday, November 12, 2010 09:42:52 Jason Kridner wrote: > On Tue, Nov 9, 2010 at 8:52 AM, Mike Frysinger wrote: > > On Friday, November 05, 2010 01:50:36 Jason Kridner wrote: > >> + if (strcmp(argv[2], "off") == 0) { > >> + state = 0; > >> + } else if (strcmp(argv[2], "on")

Re: [U-Boot] [RFC] Add 'led' command

2010-11-12 Thread Jason Kridner
Mike, Thanks for the feedback (ack to all of it). I didn't fix-up the style from the original patch given that I figured there'd be enough comments to deal with regarding the overall architecture of it, but it seems there is a need for such a generic command and this really is the easiest way to

Re: [U-Boot] [RFC] Add 'led' command

2010-11-09 Thread Mike Frysinger
On Friday, November 05, 2010 01:50:36 Jason Kridner wrote: > +int do_led ( cmd_tbl_t *cmdtp, int flag, int argc, char *argv[] ) much of the style of this code is broken. and i cant imagine this code compiling warning free with current master. no spaces around the paren, and the argv has been co

Re: [U-Boot] [RFC] Add 'led' command

2010-11-05 Thread Jason Kridner
On Fri, Nov 5, 2010 at 9:13 AM, Reinhard Meyer wrote: > Dear Wolfgang Denk, >>> It is desired to have the led command on the BeagleBoard to allow for some >>> interaction in the scripts. >>> >>> This patch allows any board implementing the coloured LED API >>> to control the LEDs from the console.

Re: [U-Boot] [RFC] Add 'led' command

2010-11-05 Thread Reinhard Meyer
Dear Wolfgang Denk, >> It is desired to have the led command on the BeagleBoard to allow for some >> interaction in the scripts. >> >> This patch allows any board implementing the coloured LED API >> to control the LEDs from the console. >> >> led [green | yellow | red | all ] [ on | off ] >> >> o

Re: [U-Boot] [RFC] Add 'led' command

2010-11-05 Thread Wolfgang Denk
Dear Jason Kridner, In message <1288936236-30603-1-git-send-email-jkrid...@beagleboard.org> you wrote: > It is desired to have the led command on the BeagleBoard to allow for some > interaction in the scripts. > > This patch allows any board implementing the coloured LED API > to control the LED

[U-Boot] [RFC] Add 'led' command

2010-11-04 Thread Jason Kridner
It is desired to have the led command on the BeagleBoard to allow for some interaction in the scripts. This patch allows any board implementing the coloured LED API to control the LEDs from the console. led [green | yellow | red | all ] [ on | off ] or led [ 1 | 2 | 3 | all ] [ on | off ] Ad