Re: [U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-30 Thread York Sun
On 04/29/2014 04:12 PM, Scott Wood wrote: On Sat, 2014-04-26 at 09:36 -0700, York Sun wrote: On 04/26/2014 02:22 AM, Wolfgang Denk wrote: +#ifdef CONFIG_PPC + gd = (gd_t *) (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET); + __asm__ __volatile__(:::memory); +#endif Again, this is

Re: [U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-29 Thread Scott Wood
On Sat, 2014-04-26 at 09:36 -0700, York Sun wrote: On 04/26/2014 02:22 AM, Wolfgang Denk wrote: +#ifdef CONFIG_PPC + gd = (gd_t *) (CONFIG_SYS_INIT_RAM_ADDR + CONFIG_SYS_GBL_DATA_OFFSET); + __asm__ __volatile__(:::memory); +#endif Again, this is a global change. Why is this now

Re: [U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-29 Thread Scott Wood
On Sat, 2014-04-26 at 21:36 +0200, Wolfgang Denk wrote: Dear York Sun, In message 535be09f.80...@freescale.com you wrote: Change return value for mac_read_from_eeprom() when mismatch happens to prevent calling hang(). You mean, you just ignore the error? This is a change of the

Re: [U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-26 Thread Wolfgang Denk
Dear York Sun, In message 1398474623-4709-1-git-send-email-york...@freescale.com you wrote: Add #ifdef CONFIG_OF_CONTROL for reserve_fdt(), setup_fdt(), reloc_fdt(). This looks wrong to me. This is a global file, and you are affecting a ton of unrelated boards. Set initial value for gd.

Re: [U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-26 Thread York Sun
On 04/26/2014 02:22 AM, Wolfgang Denk wrote: Dear York Sun, In message 1398474623-4709-1-git-send-email-york...@freescale.com you wrote: Add #ifdef CONFIG_OF_CONTROL for reserve_fdt(), setup_fdt(), reloc_fdt(). This looks wrong to me. This is a global file, and you are affecting a ton

Re: [U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-26 Thread Wolfgang Denk
Dear York Sun, In message 535be09f.80...@freescale.com you wrote: Add #ifdef CONFIG_OF_CONTROL for reserve_fdt(), setup_fdt(), reloc_fdt(). This looks wrong to me. This is a global file, and you are affecting a ton of unrelated boards. Understood it is a global file. These functions

Re: [U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-26 Thread Simon Glass
Hi York, On 26 April 2014 10:36, York Sun york...@freescale.com wrote: On 04/26/2014 02:22 AM, Wolfgang Denk wrote: Dear York Sun, In message 1398474623-4709-1-git-send-email-york...@freescale.com you wrote: Add #ifdef CONFIG_OF_CONTROL for reserve_fdt(), setup_fdt(), reloc_fdt(). This

[U-Boot] [RFC] RFC: convert MPC8536DS to use generic board

2014-04-25 Thread York Sun
This patch converts MC8536DS to use generic board. This is for discussion. Do NOT apply. To make it work Add #ifdef CONFIG_OF_CONTROL for reserve_fdt(), setup_fdt(), reloc_fdt(). Set initial value for gd. Powerpc SoCs use locked cache as init RAM. Change return value for mac_read_from_eeprom()