Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-10 Thread Grant Likely
On Thu, Aug 5, 2010 at 5:36 PM, John Rigby jcri...@gmail.com wrote: On Thu, Aug 5, 2010 at 5:26 PM, Kumar Gala ga...@kernel.crashing.org wrote: On Aug 5, 2010, at 5:14 PM, John Rigby wrote: Add fdt_fixup_memory_banks and reimplement fdt_fixup_memory to use it. Signed-off-by: John Rigby

Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-10 Thread Dan Malek
On Aug 10, 2010, at 12:39 PM, Grant Likely wrote: . At the moment, I think firmware should be restricted to only touching the /chosen node, the /memory node, I don't even want it updating these, except maybe for the processor clock speeds. I'm trying to use device trees as a mechanism

Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-10 Thread John Rigby
Kumar, Grant: On Tue, Aug 10, 2010 at 1:39 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, Aug 5, 2010 at 5:36 PM, John Rigby jcri...@gmail.com wrote: On Thu, Aug 5, 2010 at 5:26 PM, Kumar Gala ga...@kernel.crashing.org wrote: The problem w/libfdt is that use of 'offsets' to

Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-10 Thread Grant Likely
On Tue, Aug 10, 2010 at 3:03 PM, John Rigby john.ri...@linaro.org wrote: Kumar, Grant: On Tue, Aug 10, 2010 at 1:39 PM, Grant Likely grant.lik...@secretlab.ca wrote: On Thu, Aug 5, 2010 at 5:36 PM, John Rigby jcri...@gmail.com wrote: On Thu, Aug 5, 2010 at 5:26 PM, Kumar Gala

Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-10 Thread Dan Malek
On Aug 10, 2010, at 1:26 PM, Grant Likely wrote: Hi Dan! I'm glad you're reading as you're one of the use-cases I was thinking about. :-) Hi Grant. Yeah, it's me, the special case :-) ... but I gather from your comment that even that causes problems in your use-case. The /chosen

Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-10 Thread Scott Wood
On Tue, 10 Aug 2010 13:39:57 -0600 Grant Likely grant.lik...@secretlab.ca wrote: :-) I still stand on my point that hard coding device tree manipulations is asking for trouble. IMNSHO, firmware should really be restricted to very well defined things in the device tree. I've been thinking

[U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-05 Thread John Rigby
Add fdt_fixup_memory_banks and reimplement fdt_fixup_memory to use it. Signed-off-by: John Rigby john.ri...@linaro.org --- common/fdt_support.c | 86 ++--- include/fdt_support.h |1 + 2 files changed, 47 insertions(+), 40 deletions(-) diff

Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-05 Thread Kumar Gala
On Aug 5, 2010, at 5:14 PM, John Rigby wrote: Add fdt_fixup_memory_banks and reimplement fdt_fixup_memory to use it. Signed-off-by: John Rigby john.ri...@linaro.org --- common/fdt_support.c | 86 ++--- include/fdt_support.h |1 + 2 files

Re: [U-Boot] [RFC 1/3] FDT: Add fixup support of multiple banks of memory

2010-08-05 Thread John Rigby
Kumar, Right now I'm only looking a basic support. I know there are those who believe that u-boot actually does more manipulation than it should. I'll let Grant speak up if he wants to:). John On Thu, Aug 5, 2010 at 5:26 PM, Kumar Gala ga...@kernel.crashing.org wrote: On Aug 5, 2010, at