Re: [U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support

2010-08-10 Thread Grant Likely
On Thu, Aug 5, 2010 at 4:14 PM, John Rigby john.ri...@linaro.org wrote: Add device tree support for ARM.  Based on other existing implementations. Hi John, minor comments. Signed-off-by: John Rigby john.ri...@linaro.org ---  arch/arm/include/asm/config.h |    1 +  arch/arm/lib/bootm.c    

Re: [U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support

2010-08-10 Thread Albert ARIBAUD
Le 10/08/2010 21:44, Grant Likely a écrit : #if defined(CONFIG_OF_LIBFDT) -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC) +#if defined(CONFIG_PPC) || \ +defined(CONFIG_M68K) || \ +defined(CONFIG_SPARC) || \ +defined(CONFIG_ARM) There's got to be a

Re: [U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support

2010-08-10 Thread John Rigby
Thanks Albert, this is an excellent idea. On Tue, Aug 10, 2010 at 2:23 PM, Albert ARIBAUD albert.arib...@free.fr wrote: Le 10/08/2010 21:44, Grant Likely a écrit :   #if defined(CONFIG_OF_LIBFDT) -#if defined(CONFIG_PPC) || defined(CONFIG_M68K) || defined(CONFIG_SPARC) +#if

Re: [U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support

2010-08-10 Thread Wolfgang Denk
Dear John Rigby, In message aanlktin=irnma_tlcjvvaj4k-q_shqbohp33hj-0b...@mail.gmail.com you wrote: Thanks Albert, this is an excellent idea. On Tue, Aug 10, 2010 at 2:23 PM, Albert ARIBAUD albert.arib...@free.fr wr= Full quote delted. Please DO NOT top post / full quote. Thanks.

[U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support

2010-08-05 Thread John Rigby
Add device tree support for ARM. Based on other existing implementations. Signed-off-by: John Rigby john.ri...@linaro.org --- arch/arm/include/asm/config.h |1 + arch/arm/lib/bootm.c | 128 - common/cmd_bootm.c|5 +-

Re: [U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support

2010-08-05 Thread Wolfgang Denk
Dear John Rigby, In message 1281046488-25187-3-git-send-email-john.ri...@linaro.org you wrote: Add device tree support for ARM. Based on other existing implementations. ... +#ifdef CONFIG_USB_DEVICE + { + extern void udc_disconnect(void); + udc_disconnect();

Re: [U-Boot] [RFC 2/3] ARM: WIP: add flat device tree support

2010-08-05 Thread John Rigby
Thanks for the quick review. I'll make your suggested fixes and resubmit. On Thu, Aug 5, 2010 at 4:31 PM, Wolfgang Denk w...@denx.de wrote: Dear John Rigby, In message 1281046488-25187-3-git-send-email-john.ri...@linaro.org you wrote: Add device tree support for ARM.  Based on other