[U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-05 Thread Daniel Schwierzeck
[ane...@ti.com: 1. Changed the definition of OBJTREE and the way 'obj' is defined. 2. Defined a flag to identify regular U-Boot build 3. Taking care of autoconf.mk etc for SPL due to changed OBJTREE ] [daniel.schwierz...@googlemail.com: 1. reverted changes on implicite make rules 2. readded defini

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-05 Thread Mike Frysinger
On Tuesday, July 05, 2011 12:26:19 Daniel Schwierzeck wrote: > +ifdef CONFIG_UBOOT_SPL_BUILD > +# OBJTREE points to /spl/obj inside the original OBJTREE for SPL > +sinclude $(OBJTREE)/../../include/autoconf.mk > +sinclude $(OBJTREE)/../../include/config.mk > +else > sinclude $(OBJTREE)/include/aut

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-06 Thread Aneesh V
Hi Daniel, On Tuesday 05 July 2011 09:56 PM, Daniel Schwierzeck wrote: > [ane...@ti.com: > 1. Changed the definition of OBJTREE and the way 'obj' is defined. > 2. Defined a flag to identify regular U-Boot build > 3. Taking care of autoconf.mk etc for SPL due to changed OBJTREE > ] > > [daniel.schw

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Wolfgang Denk
Dear Daniel Schwierzeck, In message <1309883182-12854-2-git-send-email-daniel.schwierz...@googlemail.com> you wrote: > [ane...@ti.com: > 1. Changed the definition of OBJTREE and the way 'obj' is defined. > 2. Defined a flag to identify regular U-Boot build > 3. Taking care of autoconf.mk etc for

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Aneesh V
Dear Wolfgang, On Friday 08 July 2011 02:38 PM, Wolfgang Denk wrote: > Dear Daniel Schwierzeck, > > In > message<1309883182-12854-2-git-send-email-daniel.schwierz...@googlemail.com> > you wrote: >> [ane...@ti.com: >> 1. Changed the definition of OBJTREE and the way 'obj' is defined. >> 2. Defin

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Wolfgang Denk
Dear Aneesh V, In message <4e16d9da.4080...@ti.com> you wrote: > > >> +CONFIG_NORMAL_UBOOT = $(if $(CONFIG_UBOOT_SPL_BUILD),,y) > > > > Is this not redundant, then? > > Yes, it is. But it was handy for conditional inclusion of source files > in the Makefiles, like this: > > +# used only by norm

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Daniel Schwierzeck
Dear Wolfgang, On Fri, Jul 8, 2011 at 11:08 AM, Wolfgang Denk wrote: > Dear Daniel Schwierzeck, > > In message > <1309883182-12854-2-git-send-email-daniel.schwierz...@googlemail.com> you > wrote: >> [ane...@ti.com: >> 1. Changed the definition of OBJTREE and the way 'obj' is defined. >> 2. Defi

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Aneesh V
On Friday 08 July 2011 04:49 PM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4e16d9da.4080...@ti.com> you wrote: >> +CONFIG_NORMAL_UBOOT = $(if $(CONFIG_UBOOT_SPL_BUILD),,y) >>> >>> Is this not redundant, then? >> >> Yes, it is. But it was handy for conditional inclusion of source fi

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Wolfgang Denk
Dear Daniel Schwierzeck, In message you wrote: > > >> +# Allow compiling of C and ASM code parts in different way. > >> +# Serves also as a replacement for CONFIG_PRELOADER. > >> +ifneq ($(CONFIG_UBOOT_SPL_BUILD),) > >> +CPPFLAGS += -DCONFIG_UBOOT_SPL_BUILD > >> +endif > > > > I don't understan

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Wolfgang Denk
Dear Aneesh V, In message <4e16ecb6.5070...@ti.com> you wrote: > > >> Without CONFIG_NORMAL_UBOOT this becomes a little cumbersome. > > > > Hm... instead of > > > > COBJS-$(CONFIG_NORMAL_UBOOT) += fileA.o > > > > we could use > > > > COBJS-$(if $(CONFIG_UBOOT_SPL_BUILD),,y) > > This is what I was

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Aneesh V
Dear Wolfgang, On Friday 08 July 2011 05:55 PM, Wolfgang Denk wrote: > Dear Daniel Schwierzeck, > > In > message > you wrote: >> +# Allow compiling of C and ASM code parts in different way. +# Serves also as a replacement for CONFIG_PRELOADER. +ifneq ($(CONFIG_UBOOT_SPL_BUILD),)

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Wolfgang Denk
Dear Aneesh V, In message <4e17070e.50...@ti.com> you wrote: > > Do you confirm on replacing all instances of CONFIG_PRELOADER with > CONFIG_UBOOT_SPL_BUILD? Well, both are just names. CONFIG_PRELOADER is shorter, but we are moving more and more to the "spl" names, so maybe we can agree on

Re: [U-Boot] [RFC PATCH 1/4] Adapt config.mk for usage in spl/Makefile

2011-07-08 Thread Aneesh V
On Friday 08 July 2011 07:14 PM, Wolfgang Denk wrote: > Dear Aneesh V, > > In message<4e17070e.50...@ti.com> you wrote: >> >> Do you confirm on replacing all instances of CONFIG_PRELOADER with >> CONFIG_UBOOT_SPL_BUILD? > > Well, both are just names. CONFIG_PRELOADER is shorter, but we are > movi