Re: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-29 Thread Marek Vasut
Dear Otavio Salvador, > On Sun, Jul 29, 2012 at 9:55 AM, Marek Vasut wrote: > > Dear Otavio Salvador, > > > >> On Sun, Jul 29, 2012 at 4:00 AM, Stefano Babic wrote: > >> > Personally I prefer that the function names are the same and the > >> > implementation itself of the function hides the SOC

Re: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-29 Thread Otavio Salvador
On Sun, Jul 29, 2012 at 9:55 AM, Marek Vasut wrote: > Dear Otavio Salvador, > >> On Sun, Jul 29, 2012 at 4:00 AM, Stefano Babic wrote: >> > Personally I prefer that the function names are the same and the >> > implementation itself of the function hides the SOC details. In this >> > way, we provi

Re: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-29 Thread Marek Vasut
Dear Otavio Salvador, > On Sun, Jul 29, 2012 at 4:00 AM, Stefano Babic wrote: > > Personally I prefer that the function names are the same and the > > implementation itself of the function hides the SOC details. In this > > way, we provide the same interface API to the user (=the board > > mainta

Re: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-29 Thread Otavio Salvador
On Sun, Jul 29, 2012 at 4:00 AM, Stefano Babic wrote: > Personally I prefer that the function names are the same and the > implementation itself of the function hides the SOC details. In this > way, we provide the same interface API to the user (=the board > maintainer) and to the drivers that are

Re: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-29 Thread Marek Vasut
Dear Stefano Babic, [...] > > > > Given that the PSU regs for example have completely different register > > map and bit maps in the registers itself, I'd be careful with the > > renaming. > > Personally I prefer that the function names are the same and the > implementation itself of the functio

Re: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-29 Thread Stefano Babic
On 29/07/2012 03:33, Marek Vasut wrote: > Dear Otavio Salvador, > Hi Marek, Otavio, >> As the register accessing mode is the same for all i.MXS SoCs we ought >> to use 'mxs' prefix intead of 'mx28'. >> >> Signed-off-by: Otavio Salvador >> --- >> arch/arm/cpu/arm926ejs/mxs/clock.c |

Re: [U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-28 Thread Marek Vasut
Dear Otavio Salvador, > As the register accessing mode is the same for all i.MXS SoCs we ought > to use 'mxs' prefix intead of 'mx28'. > > Signed-off-by: Otavio Salvador > --- > arch/arm/cpu/arm926ejs/mxs/clock.c |4 +- > arch/arm/cpu/arm926ejs/mxs/iomux.c |6 +- > a

[U-Boot] [RFC PATCH 2/5] mxs: prefix register acessor macros with 'mxs' prefix

2012-07-28 Thread Otavio Salvador
As the register accessing mode is the same for all i.MXS SoCs we ought to use 'mxs' prefix intead of 'mx28'. Signed-off-by: Otavio Salvador --- arch/arm/cpu/arm926ejs/mxs/clock.c |4 +- arch/arm/cpu/arm926ejs/mxs/iomux.c |6 +- arch/arm/cpu/arm926ejs/mxs/mx28.c