Re: [U-Boot] [RFC PATCH 7/7] reboard: arm: Remove unused code in start.S

2011-12-08 Thread Simon Glass
Hi Mike, On Mon, Nov 28, 2011 at 7:15 PM, Mike Frysinger vap...@gentoo.org wrote: On Monday 21 November 2011 18:58:00 Simon Glass wrote: --- a/board/reloc.c +++ b/board/reloc.c -void new_relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr) +void relocate_code(ulong dest_addr_sp,

Re: [U-Boot] [RFC PATCH 7/7] reboard: arm: Remove unused code in start.S

2011-11-28 Thread Mike Frysinger
On Monday 21 November 2011 18:58:00 Simon Glass wrote: --- a/board/reloc.c +++ b/board/reloc.c -void new_relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr) +void relocate_code(ulong dest_addr_sp, gd_t *new_gd, ulong dest_addr) this is too fragile. we can't have every arch

[U-Boot] [RFC PATCH 7/7] reboard: arm: Remove unused code in start.S

2011-11-21 Thread Simon Glass
Now that we are using the generic relocation framework, we don't need this code. Once it is removed, we can change reloc.c's relocate_code() function back to its correct name. Note: Here we lose the ARM1176's enable_mmu code. This seems to duplicate code already in U-Boot now. Can anyone comment