Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-19 Thread Julius Werner
Migrating my comments here for public discussion. > This adds usb framework support for super-speed usb, which will > further facilitate to add stack support for xHCI. > > Signed-off-by: Vikas C Sajjan > Signed-off-by: Vivek Gautam > > --- > Changes from v2: > - Replacing if-else with switch-

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-19 Thread Marek Vasut
Hi Julius, > Migrating my comments here for public discussion. Maybe you can make a patch(set) against u-boot-usb/next ? Best regards, Marek Vasut ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-19 Thread Julius Werner
These patches haven't gone in yet, right? I think Vivek wants to discuss/update them himself, he just asked me to move my reviews to this thread. ___ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-20 Thread Marek Vasut
Dear Julius Werner, > These patches haven't gone in yet, right? I think Vivek wants to > discuss/update them himself, he just asked me to move my reviews to > this thread. They're not in, but they're already pushed in my tree. It'd be also easier to review diff instead of full patches again. Be

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-21 Thread Vivek Gautam
Hi Julius, On Fri, Apr 19, 2013 at 11:52 PM, Julius Werner wrote: > Migrating my comments here for public discussion. Thanks for your valuable comments here. > >> This adds usb framework support for super-speed usb, which will >> further facilitate to add stack support for xHCI. >> >> Signed-o

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-21 Thread Vivek Gautam
Hi Marek, On Sat, Apr 20, 2013 at 5:27 PM, Marek Vasut wrote: > Dear Julius Werner, > >> These patches haven't gone in yet, right? I think Vivek wants to >> discuss/update them himself, he just asked me to move my reviews to >> this thread. > > They're not in, but they're already pushed in my tr

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-22 Thread Julius Werner
>> I would reword "Additions" to "Changes" and explicitly state that these >> fields >> concern the new USB 3.0 hub descriptor format, which is different and >> exclusively applies to SuperSpeed hubs. > > This bit fields are actually additions to USB 3.0 framework. These > fields are not defined i

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-22 Thread Marek Vasut
Dear Vivek Gautam, > Hi Marek, > > On Sat, Apr 20, 2013 at 5:27 PM, Marek Vasut wrote: > > Dear Julius Werner, > > > >> These patches haven't gone in yet, right? I think Vivek wants to > >> discuss/update them himself, he just asked me to move my reviews to > >> this thread. > > > > They're no

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-22 Thread Vivek Gautam
Hi Julius, On Tue, Apr 23, 2013 at 3:44 AM, Julius Werner wrote: >>> I would reword "Additions" to "Changes" and explicitly state that these >>> fields >>> concern the new USB 3.0 hub descriptor format, which is different and >>> exclusively applies to SuperSpeed hubs. >> >> This bit fields are

Re: [U-Boot] [U-Boot, v3, 6/8] USB: SS: Add support for Super Speed USB interface

2013-04-22 Thread Vivek Gautam
Hi Marek, On Tue, Apr 23, 2013 at 7:54 AM, Marek Vasut wrote: > Dear Vivek Gautam, > >> Hi Marek, >> >> On Sat, Apr 20, 2013 at 5:27 PM, Marek Vasut wrote: >> > Dear Julius Werner, >> > >> >> These patches haven't gone in yet, right? I think Vivek wants to >> >> discuss/update them himself, he