Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-14 Thread Lukasz Majewski
Dear Simon, Eddie, > >> > >> Let's convert them soon! > > Does it means i can keep it in rk3288_common.h? > > Anything new you add must go into defconfig. If it depends on a > non-Kconfig option, then just leave out the depend. We cannot add new > things to the config whitelist, so you should

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-14 Thread Simon Glass
Hi Eddie, On 4 May 2017 at 19:15, Eddie Cai wrote: > 2017-05-05 0:49 GMT+08:00 Simon Glass : >> Hi, >> >> On 4 May 2017 at 03:19, Lukasz Majewski wrote: >>> Hi Eddie, Simon, >>> Hi Simon 2017-05-03 18:09 GMT+08:00 Simon Glass : > Hi Eddie, > > On 2 May 2017 at 04:37

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-04 Thread Eddie Cai
2017-05-05 0:49 GMT+08:00 Simon Glass : > Hi, > > On 4 May 2017 at 03:19, Lukasz Majewski wrote: >> Hi Eddie, Simon, >> >>> Hi Simon >>> >>> 2017-05-03 18:09 GMT+08:00 Simon Glass : >>> > Hi Eddie, >>> > >>> > On 2 May 2017 at 04:37, Eddie Cai wrote: >>> >> Hi Simon >>> >> 2017-03-20 10:30 GMT+08

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-04 Thread Simon Glass
Hi, On 4 May 2017 at 03:19, Lukasz Majewski wrote: > Hi Eddie, Simon, > >> Hi Simon >> >> 2017-05-03 18:09 GMT+08:00 Simon Glass : >> > Hi Eddie, >> > >> > On 2 May 2017 at 04:37, Eddie Cai wrote: >> >> Hi Simon >> >> 2017-03-20 10:30 GMT+08:00 Simon Glass : >> >>> Hi Eddie. >> >>> >> >>> On 15

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-04 Thread Lukasz Majewski
Hi Eddie, Simon, > Hi Simon > > 2017-05-03 18:09 GMT+08:00 Simon Glass : > > Hi Eddie, > > > > On 2 May 2017 at 04:37, Eddie Cai wrote: > >> Hi Simon > >> 2017-03-20 10:30 GMT+08:00 Simon Glass : > >>> Hi Eddie. > >>> > >>> On 15 March 2017 at 01:56, Eddie Cai > >>> wrote: > this patch ena

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-04 Thread Eddie Cai
Hi Simon 2017-05-03 18:09 GMT+08:00 Simon Glass : > Hi Eddie, > > On 2 May 2017 at 04:37, Eddie Cai wrote: >> Hi Simon >> 2017-03-20 10:30 GMT+08:00 Simon Glass : >>> Hi Eddie. >>> >>> On 15 March 2017 at 01:56, Eddie Cai wrote: this patch enable rockusb support on rk3288 based device.

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-03 Thread Simon Glass
Hi Eddie, On 2 May 2017 at 04:37, Eddie Cai wrote: > Hi Simon > 2017-03-20 10:30 GMT+08:00 Simon Glass : >> Hi Eddie. >> >> On 15 March 2017 at 01:56, Eddie Cai wrote: >>> this patch enable rockusb support on rk3288 based device. >>> >>> Signed-off-by: Eddie Cai >>> --- >>> include/configs/rk3

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-05-02 Thread Eddie Cai
Hi Simon 2017-03-20 10:30 GMT+08:00 Simon Glass : > Hi Eddie. > > On 15 March 2017 at 01:56, Eddie Cai wrote: >> this patch enable rockusb support on rk3288 based device. >> >> Signed-off-by: Eddie Cai >> --- >> include/configs/rk3288_common.h | 4 >> 1 file changed, 4 insertions(+) > > I t

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-04-20 Thread Lukasz Majewski
Hi Eddie, > this patch enable rockusb support on rk3288 based device. > > Signed-off-by: Eddie Cai > --- > include/configs/rk3288_common.h | 4 > 1 file changed, 4 insertions(+) > > diff --git a/include/configs/rk3288_common.h > b/include/configs/rk3288_common.h index b5606d4..b19a34d 100

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-03-20 Thread Eddie Cai
Hi Simon 2017-03-20 10:30 GMT+08:00 Simon Glass : > Hi Eddie. > > On 15 March 2017 at 01:56, Eddie Cai wrote: > > this patch enable rockusb support on rk3288 based device. > > > > Signed-off-by: Eddie Cai > > --- > > include/configs/rk3288_common.h | 4 > > 1 file changed, 4 insertions(+)

Re: [U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-03-19 Thread Simon Glass
Hi Eddie. On 15 March 2017 at 01:56, Eddie Cai wrote: > this patch enable rockusb support on rk3288 based device. > > Signed-off-by: Eddie Cai > --- > include/configs/rk3288_common.h | 4 > 1 file changed, 4 insertions(+) I think this should be done in Kconfig. > > diff --git a/include/c

[U-Boot] [U-Boot 3/3] rockchip: rk3288: enable rockusb support on rk3288 based device

2017-03-15 Thread Eddie Cai
this patch enable rockusb support on rk3288 based device. Signed-off-by: Eddie Cai --- include/configs/rk3288_common.h | 4 1 file changed, 4 insertions(+) diff --git a/include/configs/rk3288_common.h b/include/configs/rk3288_common.h index b5606d4..b19a34d 100644 --- a/include/configs/rk3