Re: [U-Boot] [linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-17 Thread Tom Rini
On Sun, Mar 16, 2014 at 03:09:01PM +, Ian Campbell wrote: > On Fri, 2014-03-14 at 10:22 -0400, Tom Rini wrote: > > On Fri, Mar 14, 2014 at 11:28:06AM +, Ian Campbell wrote: > > > On Fri, 2014-03-14 at 19:11 +0800, Chen-Yu Tsai wrote: > > [snip] > > > > I think you should keep them in the sa

Re: [U-Boot] [linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-16 Thread Ian Campbell
On Fri, 2014-03-14 at 10:22 -0400, Tom Rini wrote: > On Fri, Mar 14, 2014 at 11:28:06AM +, Ian Campbell wrote: > > On Fri, 2014-03-14 at 19:11 +0800, Chen-Yu Tsai wrote: > [snip] > > > I think you should keep them in the same patch. You can then > > > just add the appropriate config options whe

Re: [U-Boot] [linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-14 Thread Tom Rini
On Fri, Mar 14, 2014 at 11:28:06AM +, Ian Campbell wrote: > On Fri, 2014-03-14 at 19:11 +0800, Chen-Yu Tsai wrote: [snip] > > I think you should keep them in the same patch. You can then > > just add the appropriate config options when support of other A20 > > boards roll in. > > I don't have

Re: [U-Boot] [linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-14 Thread Chen-Yu Tsai
On Fri, Mar 14, 2014 at 6:33 PM, Ian Campbell wrote: > Based linux-sunxi#sunxi commit d854c4de2f57 "arm: Handle .gnu.hash section in > ldscripts" vs v2014.01. > > Signed-off-by: Chen-Yu Tsai > Signed-off-by: Jens Kuske > Signed-off-by: Ian Campbell > --- > arch/arm/cpu/armv7/sunxi/board.c | 15

Re: [U-Boot] [linux-sunxi] [PATCH v1 9/9] sunxi: add gmac Ethernet support

2014-03-14 Thread Ian Campbell
On Fri, 2014-03-14 at 19:11 +0800, Chen-Yu Tsai wrote: > Thanks for working on this! No problem. > I see you left out all the CONFIG_RGMII ifdefs from this file. Not > sure if it's because you're aiming to support only the Cubietruck > first. Yes, exactly. > I think you should keep them in the