Re: [U-Boot] [review request] cmd_bmp.c: added standard subcommand handling

Hi Frans, > This is not a formal patch but a review request. > Do people feel this patch is desirable and ok? I feel it is desirable yes. > and should I keep it like this, or should I merge do_bmp_info and > bmp_info into one func (and similarly for do_bmp_display and > bmp_display) I'd vote to

[U-Boot] [review request] cmd_bmp.c: added standard subcommand handling

--- Hi, This is not a formal patch but a review request. Do people feel this patch is desirable and ok? and should I keep it like this, or should I merge do_bmp_info and bmp_info into one func (and similarly for do_bmp_display and bmp_display) and please ignore the superfluous int x = 0, y = 0;