Re: [U-Boot] [PATCH] KGDB set / remove breakpoints

2010-04-20 Thread Mike Frysinger
On Monday 19 April 2010 04:54:50 Tonny Tzeng wrote: Please note, after applying this patch, those architectures, which already enabled KGDB support, have to create a new asm/kgdb.h and define the length of the break instruction (BREAK_INSTR_SIZE) in that file. i dont think breaking

Re: [U-Boot] [PATCH] KGDB set / remove breakpoints

2010-04-19 Thread Tonny Tzeng
Thanks for the review, Mike. Please note, after applying this patch, those architectures, which already enabled KGDB support, have to create a new asm/kgdb.h and define the length of the break instruction (BREAK_INSTR_SIZE) in that file. i dont think breaking build is a good idea.  i would

[U-Boot] [PATCH] KGDB set / remove breakpoints

2010-04-17 Thread Tonny Tzeng
This patch extends the current KGDB logic to handle 'Z' and 'z' GDB packets for setting or removing breakpoints. Two weak functions have been added to the kgdb_stub.c: arch_kgdb_set_sw_break() and arch_kgdb_remove_sw_break() could be overrode by the arch implementations. Please note, after

Re: [U-Boot] [PATCH] KGDB set / remove breakpoints

2010-04-17 Thread Mike Frysinger
On Saturday 17 April 2010 13:20:11 Tonny Tzeng wrote: This patch extends the current KGDB logic to handle 'Z' and 'z' GDB packets for setting or removing breakpoints. Two weak functions have been added to the kgdb_stub.c: arch_kgdb_set_sw_break() and arch_kgdb_remove_sw_break() could be