Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Wolfgang Denk
Dear =?ISO-8859-2?Q?Viktor_K=F8iv=E1k?=, In message cajxx_aysp3co1cassngycqe_ydnibcmrwj7p6ggr6t-d9qb...@mail.gmail.com you wrote: And even if it was, the combination of -ffunction-sections / -fdata-sections with --gc-sections should prevent any damages. ... Yes that's the main problem.

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Marek Vasut
Dear Wolfgang Denk, Dear =?ISO-8859-2?Q?Viktor_K=F8iv=E1k?=, In message CAJxx_aysp3cO1CasSNgycqE_yDNiBcMRwJ7P6GGR6T-d9QbB- a...@mail.gmail.com you wrote: And even if it was, the combination of -ffunction-sections / -fdata-sections with --gc-sections should prevent any damages. ...

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Timur Tabi
Marek Vasut wrote: Sure, but I see no point in keeping such dead code in U-Boot code base. Aka. why keep functions in U-Boot that are never used? I think what Wolfgang is trying to say is that no one has proven that there actually IS any unused code. The ATI driver needs the BIOS emulator,

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Marek Vasut
Dear Timur Tabi, Marek Vasut wrote: Sure, but I see no point in keeping such dead code in U-Boot code base. Aka. why keep functions in U-Boot that are never used? I think what Wolfgang is trying to say is that no one has proven that there actually IS any unused code. The ATI driver

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Timur Tabi
Marek Vasut wrote: Agreed, but I expected there was some dead code and that was the point I was trying to express ;-) Well, until you do a thorough analysis, you really have no idea if there is any dead code at all. -- Timur Tabi Linux kernel developer at Freescale

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Marek Vasut
Dear Timur Tabi, Marek Vasut wrote: Agreed, but I expected there was some dead code and that was the point I was trying to express ;-) Well, until you do a thorough analysis, you really have no idea if there is any dead code at all. I don't ... but Viktor probably does and I believe

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Viktor Křivák
Dear Timur Tabi, 2012/3/27 Marek Vasut ma...@denx.de: Dear Timur Tabi, Marek Vasut wrote: Agreed, but I expected there was some dead code and that was the point I was trying to express ;-) Well, until you do a thorough analysis, you really have no idea if there is any dead code at all.

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Graeme Russ
Hi Viktor, On Wed, Mar 28, 2012 at 9:46 AM, Viktor Křivák viktor.kri...@gmail.com wrote: Dear Timur Tabi, 2012/3/27 Marek Vasut ma...@denx.de: Dear Timur Tabi, Marek Vasut wrote: Agreed, but I expected there was some dead code and that was the point I was trying to express ;-) Well,

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Marek Vasut
Dear Graeme Russ, Hi Viktor, On Wed, Mar 28, 2012 at 9:46 AM, Viktor Křivák viktor.kri...@gmail.com wrote: Dear Timur Tabi, 2012/3/27 Marek Vasut ma...@denx.de: Dear Timur Tabi, Marek Vasut wrote: Agreed, but I expected there was some dead code and that was the point I

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Graeme Russ
Hi Marek, On Wed, Mar 28, 2012 at 10:46 AM, Marek Vasut ma...@denx.de wrote: Dear Graeme Russ, Hi Viktor, On Wed, Mar 28, 2012 at 9:46 AM, Viktor Křivák viktor.kri...@gmail.com wrote: Dear Timur Tabi, 2012/3/27 Marek Vasut ma...@denx.de: Dear Timur Tabi, Marek Vasut wrote:

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Marek Vasut
Dear Graeme Russ, Hi Marek, On Wed, Mar 28, 2012 at 10:46 AM, Marek Vasut ma...@denx.de wrote: Dear Graeme Russ, Hi Viktor, On Wed, Mar 28, 2012 at 9:46 AM, Viktor Křivák viktor.kri...@gmail.com wrote: Dear Timur Tabi, 2012/3/27 Marek Vasut ma...@denx.de: Dear

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Graeme Russ
Marek, Perfection is reached, not when there is no longer anything to add, but when there is no longer anything to take away.  -- Antoine de Saint-Exupery And: Not all that is simple is perfect. However, all that is perfect is simple -- Unkown :)

Re: [U-Boot] BIOS EMULATOR driver

2012-03-27 Thread Marek Vasut
Dear Graeme Russ, Marek, Perfection is reached, not when there is no longer anything to add, but when there is no longer anything to take away. -- Antoine de Saint-Exupery And: Not all that is simple is perfect. However, all that is perfect is simple -- Unkown :) That's

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Marek Vasut
Dear Wolfgang Denk, Dear Viktor, In message cajxx_awwp1wslhu0e0dzk+zhayfjy+98aaco9f_6kxswzkk...@mail.gmail.com you wrote: I'm working on one project about bios emulator and I notice that this driver is linked for boards P1022DS and sequoia too, but they don't really use any

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Wolfgang Denk
Dear Marek Vasut, In message 201203261243.19732.ma...@denx.de you wrote: I pretty sure because I try compile it without this driver and everything seems to be ok. In the given configurations, the BIOS code only gets built when you the ATI Radeon support is enabled, in which case it

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Marek Vasut
Dear Wolfgang Denk, Dear Marek Vasut, In message 201203261243.19732.ma...@denx.de you wrote: I pretty sure because I try compile it without this driver and everything seems to be ok. In the given configurations, the BIOS code only gets built when you the ATI Radeon support

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Viktor Křivák
Dear Marek and Wolfgang, 2012/3/26 Wolfgang Denk w...@denx.de: Dear Marek Vasut, In message 201203261243.19732.ma...@denx.de you wrote: I pretty sure because I try compile it without this driver and everything seems to be ok. In the given configurations, the BIOS code only gets

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Anatolij Gustschin
Hi Viktor, On Mon, 26 Mar 2012 15:47:57 +0200 Viktor Křivák viktor.kri...@gmail.com wrote: ... What exactly was your concern? I think here may be a little misunderstanding. I don't want to remove whole driver. I only want to remove support of bios emulator form that 2 board because I

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Timur Tabi
Viktor Křivák wrote: I think here may be a little misunderstanding. I don't want to remove whole driver. I only want to remove support of bios emulator form that 2 board because I think they don't use it. I try compile it without this driver and everything seems to be ok. I think it's okay to

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Wolfgang Denk
Dear Marek Vasut, In message 201203261531.18334.ma...@denx.de you wrote: So that means the board work without this bios emulator driver if the radeon driver is disabled? But we want to use the radeon driver, so we need the bios emulator stuff. Right. If you don't need feature X and do

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Wolfgang Denk
Dear Timur Tabi, In message 4f70804a.5030...@freescale.com you wrote: I think here may be a little misunderstanding. I don't want to remove whole driver. I only want to remove support of bios emulator form that 2 board because I think they don't use it. I try compile it without this

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Marek Vasut
Dear Wolfgang Denk, Dear Marek Vasut, In message 201203261531.18334.ma...@denx.de you wrote: So that means the board work without this bios emulator driver if the radeon driver is disabled? But we want to use the radeon driver, so we need the bios emulator stuff. Right. If you don't

Re: [U-Boot] BIOS EMULATOR driver

2012-03-26 Thread Viktor Křivák
Dear Wolfgang Denk and Marek Vasut, 2012/3/27 Marek Vasut marek.va...@gmail.com: Dear Wolfgang Denk, Dear Marek Vasut, In message 201203261531.18334.ma...@denx.de you wrote: So that means the board work without this bios emulator driver if the radeon driver is disabled? But we want to

[U-Boot] BIOS EMULATOR driver

2012-03-25 Thread Viktor Křivák
Hello, I'm working on one project about bios emulator and I notice that this driver is linked for boards P1022DS and sequoia too, but they don't really use any methods of it. It's safe to remove this support from configs files? Whole this driver is seems to be imported from somewhere and lots of

Re: [U-Boot] BIOS EMULATOR driver

2012-03-25 Thread Wolfgang Denk
Dear Viktor, In message CAJxx_ay7FAz-SJ0k2cBqWd1meVhDqm6vtESy=T6f9rs=kat...@mail.gmail.com you wrote: I'm working on one project about bios emulator and I notice that this driver is linked for boards P1022DS and sequoia too, but they don't really use any methods of it. It's safe to remove

Re: [U-Boot] BIOS EMULATOR driver

2012-03-25 Thread Viktor Křivák
Dear Wolfgang, I'm working on one project about bios emulator and I notice that this driver is linked for boards P1022DS and sequoia too, but they don't really use any methods of it. It's safe to remove this support from configs files? Are you sure that the code is not used? I pretty