Re: [U-Boot] Compilation warning: "MSR_RI" redefined

2009-04-03 Thread Wolfgang Denk
Dear Detlev, In message you wrote: > > Attached is a patch which fixes this fallout and starts a round of > cleanups. Please submit patches inline, not as attachments! > Subject: [PATCH] Rename common ns16550 constants with UART_ prefix to prevent > conflicts > > Fix problems introduced in co

Re: [U-Boot] Compilation warning: "MSR_RI" redefined

2009-04-03 Thread Detlev Zundel
Hi, > On Apr 2, 2009, at 4:03 AM, Stefan Roese wrote: > >> On Thursday 02 April 2009, Detlev Zundel wrote: I suggest to either remove this MSI_RI from the header again (it doesn't seem to be used here) or rename it. >>> >>> Ok, so much for the plan to add the defines not bit by bit

Re: [U-Boot] Compilation warning: "MSR_RI" redefined

2009-04-02 Thread Kumar Gala
On Apr 2, 2009, at 4:03 AM, Stefan Roese wrote: > On Thursday 02 April 2009, Detlev Zundel wrote: >>> I suggest to either remove this MSI_RI from the header again (it >>> doesn't >>> seem to be used here) or rename it. >> >> Ok, so much for the plan to add the defines not bit by bit as needed,

Re: [U-Boot] Compilation warning: "MSR_RI" redefined

2009-04-02 Thread Stefan Roese
On Thursday 02 April 2009, Detlev Zundel wrote: > > I suggest to either remove this MSI_RI from the header again (it doesn't > > seem to be used here) or rename it. > > Ok, so much for the plan to add the defines not bit by bit as needed, > but register-wise, while we're there. > > I actually would

Re: [U-Boot] Compilation warning: "MSR_RI" redefined

2009-04-02 Thread Detlev Zundel
Hi Stefan, > your patch 7b5611cdd12ca0cc33f994f0d4a4454788fc3124 [inka4x0: Add hardware > diagnosis functions for inka4x0] introduced all kind of new defines in the > ns16550.h header resulting in a warning on some 4xx platforms: > > [ste...@kubuntu u-boot (master)]$ ./MAKEALL ml300 > Configurin

[U-Boot] Compilation warning: "MSR_RI" redefined

2009-04-01 Thread Stefan Roese
Hi Detlev, your patch 7b5611cdd12ca0cc33f994f0d4a4454788fc3124 [inka4x0: Add hardware diagnosis functions for inka4x0] introduced all kind of new defines in the ns16550.h header resulting in a warning on some 4xx platforms: [ste...@kubuntu u-boot (master)]$ ./MAKEALL ml300 Configuring for ml300